Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghTXU-0001vO-6K for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Jan 2019 06:10:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ghTXS-0004pC-S6 for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Jan 2019 06:09:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghTXS-0004p4-LH for pgsql-bugs@lists.postgresql.org; Thu, 10 Jan 2019 06:09:58 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghTXQ-0006JJ-1P for pgsql-bugs@lists.postgresql.org; Thu, 10 Jan 2019 06:09:58 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 56EB61438; Thu, 10 Jan 2019 01:09:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 10 Jan 2019 01:09:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=zZSjlw0cBOtfj2U6d4C3tg6/7cI A/rVElOCmY0PCn/M=; b=Yxt8BvHQ3hjFTpJpPwN+mWV2WfKoZPONbOtRLQGfZMl ekir8QRnamxTgYhG/jV8o7fd8RYwSJMBYEz2l4n8/qmbr4cz6ZHu/yNOVLooavhp Ajp1/PshfdX6U39ihpm3ypdW/EaSB63ZE+32CGNF6Bz6Usc6usQ6gU3xngxVfkx+ Bube52FMTLhNl+lF1f1WoJHcqdHai9GPQ4Q2UmCek3WX+BMHUYjA5ceP92mEwU5H zRf/pga9xE29y2kl8MKOrpZkIMXNmfIsN4XPj0SDC8ORPHmuiWEHIDiiyUdu9GIF rGyeXKqSersqzHeoHCIFNBOsgnSamUG0ODIUAHDSydg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zZSjlw 0cBOtfj2U6d4C3tg6/7cIA/rVElOCmY0PCn/M=; b=b90AF4d5v6CQcKZb05CAN9 otPyY2iGmwxu2/7hMhcHlAmiV77AyeGRM7lrXJzM5ZZoQ5imrfWTYFO5cTd1ZJ+p oKnmmPZBMwsLco1uOsFohu2CDeOGkHARjIxGDZKh0M78DaG64F4fANN6QiyBQR8o XL1V80ypgUu4TusFKaXpphZJcGdf2MU6KCNAu88OT/tI4kfagTfpDAqEbyvymujE WZ1OMpjzccIRVoWo285+1pabYiHJ+Wc4NFF9Gjt4CGPEqLcL1bivtkCthBgo0eQP rcOzbzmCgzocVBQYQh8pGZThQpGmVmaoqyz+XknI6jhafLlyw7JiH+uxQ1/3JcZw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedvgdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdljedtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghh rggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenuc fkphepiedurddvudehrddufeejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm ihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 566A2E435E; Thu, 10 Jan 2019 01:09:48 -0500 (EST) Date: Thu, 10 Jan 2019 15:09:45 +0900 From: Michael Paquier To: Hugh Ranalli Cc: Tom Lane , Alvaro Herrera , Peter Eisentraut , thomas.munro@enterprisedb.com, Daniel Verite , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters Message-ID: <20190110060945.GL2157@paquier.xyz> References: <201901031819.hi4hjki2pzr5@alvherre.pgsql> <23619.1546539744@sss.pgh.pa.us> <20190104130048.GD2067@paquier.xyz> <20190109035253.GF21835@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g6DVDhPhk1bqxDrC" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --g6DVDhPhk1bqxDrC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 09, 2019 at 09:52:05PM -0500, Hugh Ranalli wrote: > Thank you for putting so much effort into this. I think that looks great. > When I was doing this, I discovered that I could parse both pre- and post- > r29 versions, so I went with that, but I agree that there's probably no > good reason to do so. OK, committed then. I have yet to study yet the other part of the proposal regarding diatritical characters. Patch 3 has a conflict for the regression tests, so a rebase would be needed. That's not a big deal though to resolve the conflict. I am also a bit confused by the newly-generated unaccent.rules. Why nothing shows up for the second column (around line 414 for example)? Shouldn't we have mapping characters? -- Michael --g6DVDhPhk1bqxDrC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlw24akACgkQnvQgOdby QH33Tw//azDhqI1v2svkL/PMSFI2gqUe7j+/sJmKTzaDDLHuVnMs4Y/9LMxf1UEc 7y5esV9i6wa3a/NfK0Q9gA6gp6T0fAoU/aAVrs81hgmFa4fxF1/D0RbdgJ7M1q6c WqsPDQsx5TWjIjYc3HyjfNkCdZfdhllqBIrbUoU3LmOGdWywMhAT4VQDCDF87tio O73ytk7guEEfWoGkk+UkcIvJyTgy07IXTjJXTjVkny1xsKoWVzwn1zCxx6o2NxnP JrFzDZGhuhkAWWVIa71qhgUB7ZnkNikc1OB2TUl9deLUzS2f9Ko4wld9Xk7aRI25 Fl3CWJ+WxH46lWoDsiXEtTQNVmFlZfImGFO4P90kfSz22w+8EFtlfSFJ5jq8iQcJ CEbC/Ws9j38OeNfLmqG8Tehb3S3+OPXCYlfh5iPMQWL7JKJztO/DyuBNLkoxsxZf hQBkZrirlA7/mbMMJ4Ru+92z7g88wEoMNf/LQ/TDvq5XLPUCpGa2HRms4S7N+o/d rA/SVl5Sh6cBNipsnOw/xC9qDjxRq7JYQkf0od1JIaFBLOOWHXwDpMjfcbVYHdy5 FTFhLVayQG9+agXk1b3v1nKp4FmaWZwsrAMGiigcmt496CA47xBc3NoBDhKdJq6N lsT8i4GWnTo4ZHnNk8nNSflhjgP/XLDa9AlWifKw8jbh+v+bKBU= =/ZDf -----END PGP SIGNATURE----- --g6DVDhPhk1bqxDrC--