Date: Mon, 28 Jan 2019 15:45:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Hugh Ranalli <hugh@whtc.ca>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	thomas.munro@enterprisedb.com,
	Daniel Verite <daniel@manitou-mail.org>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical
 characters
Message-ID: <20190128064545.GD15401@paquier.xyz>
References: <201901031819.hi4hjki2pzr5@alvherre.pgsql>
 <23619.1546539744@sss.pgh.pa.us>
 <CAAhbUMMrNL9uXXpwS+BPTGjKQv5Sxvr+OY2C73Ag7oFyjSOiEQ@mail.gmail.com>
 <20190104130048.GD2067@paquier.xyz>
 <CAAhbUMOj8r4=V0nQpa21SBh7tHTZ37QxXKx5JSpYqdsA-V6mSA@mail.gmail.com>
 <20190109035253.GF21835@paquier.xyz>
 <CAAhbUMNZ0ooK6SzLNdkxzdBsQHOJf_rg_EjwoNL8QHTwQuriRw@mail.gmail.com>
 <20190110060945.GL2157@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h"
Content-Disposition: inline
In-Reply-To: <20190110060945.GL2157@paquier.xyz>
Precedence: bulk


--veXX9dWIonWZEC6h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Thomas,

On Thu, Jan 10, 2019 at 03:09:45PM +0900, Michael Paquier wrote:
> OK, committed then. I have yet to study yet the other part of the
> proposal regarding diatritical characters.  Patch 3 has a conflict for
> the regression tests, so a rebase would be needed.  That's not a big
> deal though to resolve the conflict.  I am also a bit confused by the
> newly-generated unaccent.rules.  Why nothing shows up for the second
> column (around line 414 for example)?  Shouldn't we have mapping
> characters?

You are registered as a reviewer and committer of the last patch of
this thread:
https://commitfest.postgresql.org/21/1924/

Are you planning to look at it or should I jump in?  I have not looked
at the patch status in depth yet.
--
Michael

--veXX9dWIonWZEC6h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxOpRkACgkQnvQgOdby
QH2VLA/9EQ2OAt18kGcGqFy9dvWiUYJrN1JTi+VBoUQ/biQ/ynJjalkgb/rMy6Fc
+b91kC0bgqTm/LrgV9yFK/n+AR5ZWv+QWHBWYhfJN4qTswdZFghF0VoVXYV3S3Nc
+hhblwudEgeb05Qz3O//0/RNCEzhSbBmAfXdvaKHmwKcKb9WkStF115F37JOtlmZ
n2Q+1iTN309PK6qrveJ8ex/rTvM9KnS0+RxPUxg+I5HblfKs3QscfYW+0j6s0kO9
x/6U5xckdYB6cT1zscN+5zdYU7clNfun+7gOeQ60MloXftrFXvX9XyXvWXG5hEnd
Wx9mdYULdsfQuvUer9L+6mqvoV+O3nNJR8iGL8WwDrTuAJ4BWRjJIjBH83K0Qk0l
aeTII53FYi4t+NE6vVPprcIOzgry/7eYa+WliCYN1n+2VJXz7GMdzKobJ24dfsl0
re1EEqezy1+3gKU/lj7T92aCDiv8feCr/y0J9ckPY7RSUuUDk6yNAKmwqB5p0cLt
/Yn8VcmN/gSil+y1+fUwA3IM3U80Tdy9jLINDNAldtqWRNuLeveydydhkpJwYI2i
PC/NBhoqywPE5v8iUATJuKqo1Avz2DsqqWi7hxOhl0vmrJlHdwhiSsQKXxS+ZwYu
VTICYGj7Nn2tOr4jJzHgm1zfu6tESYXF66JTLeS3sn/YxXuPmvk=
=3mLm
-----END PGP SIGNATURE-----

--veXX9dWIonWZEC6h--