Date: Mon, 18 Feb 2019 11:55:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: John Klann <jk7255@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS
 destination throws fsync error at end of backup
Message-ID: <20190218025511.GA15532@paquier.xyz>
References: 
 <CAHyX5+VcEtcoOAo4QQ_20gv7kLYBDnx_YOAnEJQN9KftH0qp9Q@mail.gmail.com>
 <CAEepm=0eC5ySeOsXMqXQFeJ64mhgAqxAyuh7JpjCz7uT2Ld0jQ@mail.gmail.com>
 <CAHyX5+XqkmHwxLC5aeYOjHFAvnf8X1o3grkzGJOvc-kOGpjQ8g@mail.gmail.com>
 <CAHyX5+VO-UTE-pK2i1rWvweU2CpVtHuhXnok29Z66EpLHmiHvw@mail.gmail.com>
 <CAEepm=05ff+GRYdVE7+SdDuTVbPqW+Gmpwqir0NtAWNM70jg3g@mail.gmail.com>
 <CAHyX5+W2OXAg=qEnObA3g4zU3SkwxTztSfmgmivWnWQWcsc_tA@mail.gmail.com>
 <CAEepm=1P0WD_g=ELNmBJFhwKuCjYZOi4p4rutKj3kw7QneLB2A@mail.gmail.com>
 <CAHyX5+UxmOn-qpb+++NOr3MfZiXk6WZDKFYTEj+vPbu+3nrhXg@mail.gmail.com>
 <CAHyX5+X60D0jtf4dgyt11mH=7XvuW1UOLstY9sBLgukyf8Oo4g@mail.gmail.com>
 <CAEepm=27vTw2xyTh5kAXns8h5zOKUmzBxUL82c-KFFgyUQ0MHw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z"
Content-Disposition: inline
In-Reply-To: 
 <CAEepm=27vTw2xyTh5kAXns8h5zOKUmzBxUL82c-KFFgyUQ0MHw@mail.gmail.com>
Precedence: bulk


--7AUc2qLy4jB3hD7Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 18, 2019 at 02:34:15PM +1300, Thomas Munro wrote:
> You mentioned that you were on RHEL 7.5, which ships with a 3.10
> kernel.  When you eventually move to RHEL 8 (4.x) or even install an
> alternative newer kernel for 7.x, the problem will hopefully go away
> by itself.  Considering that, the lack of other complaints, and the
> availability of a workaround (--no-sync followed by "sync"), I'm not
> so sure it's worth committing this.

If we get to ignore EINVAL, then we won't know that fsync has failed
even in cases where the caller has done an incorrect thing by using a
special file, which sounds like a bad idea for the core code as much
as any plugins calling that?
--
Michael

--7AUc2qLy4jB3hD7Z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxqHo8ACgkQnvQgOdby
QH0TmA//QE/2DmZkgrCI+GfQAXye74g2fhVkzxdzwqWRMg6XtWe2XSvIQbY4fNa8
gHIfv6BVkEUTI4/mxGJdMl5myCcBMqUq09NS5lDJoTnSra8JvwQLhL2OnanB0O0i
MCBh4k4zz+6N89FDlbNYwjaMkHfGGMOqaSZT2xSyQCcguWL6Yb0OBldNBpbMf+vE
11msBO4xzMpSH6mxbWLeCpteBMs8hOpFb1oVhweN5rcvjYRQRlbJg3h7AAeQ49mV
7wpYneOyGwbS74FAQ/h5vIpp1xvAx3NmMbWnOmCFJVCNJBHL7x+uGMKKmXhYX8iQ
oA1KtOFiGr4QjxlNHJMC2RxR3U0t6XsOkqO4gT4lCofnuCgBIZW2c6b1YYpseGJN
nE0GfYfO4+6YDXJZxP0rvyQeeNERCEaieN2gwepfeL+XC4nsDi2hwX+LOe4G5jtV
GnTpIaMfY0UGXv/W0XR10PBdYF4KkzQkcfxPu9XtyYnd/h1HTqiUupe3zG+tF8KR
VZgjeYHeWgHCT/Zjen0JV0L8H+0/uO7IZPII0+HqNJ/6kCbN1+uNi4jowNVhbTI/
EjZCoUeZM3ylXwB9Pl4+nXQu/qK3lhCVtFerUYmQVGeLgdbisaaTvGa/mdXWsjz3
0riTyLkzB+XylJS8O+rEt0E7C51Yj2lw7j8bVWSZjcSuerzyCDc=
=BGTM
-----END PGP SIGNATURE-----

--7AUc2qLy4jB3hD7Z--