Date: Mon, 18 Feb 2019 12:28:43 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: John Klann <jk7255@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS
 destination throws fsync error at end of backup
Message-ID: <20190218032843.GD15532@paquier.xyz>
References: 
 <CAHyX5+XqkmHwxLC5aeYOjHFAvnf8X1o3grkzGJOvc-kOGpjQ8g@mail.gmail.com>
 <CAHyX5+VO-UTE-pK2i1rWvweU2CpVtHuhXnok29Z66EpLHmiHvw@mail.gmail.com>
 <CAEepm=05ff+GRYdVE7+SdDuTVbPqW+Gmpwqir0NtAWNM70jg3g@mail.gmail.com>
 <CAHyX5+W2OXAg=qEnObA3g4zU3SkwxTztSfmgmivWnWQWcsc_tA@mail.gmail.com>
 <CAEepm=1P0WD_g=ELNmBJFhwKuCjYZOi4p4rutKj3kw7QneLB2A@mail.gmail.com>
 <CAHyX5+UxmOn-qpb+++NOr3MfZiXk6WZDKFYTEj+vPbu+3nrhXg@mail.gmail.com>
 <CAHyX5+X60D0jtf4dgyt11mH=7XvuW1UOLstY9sBLgukyf8Oo4g@mail.gmail.com>
 <CAEepm=27vTw2xyTh5kAXns8h5zOKUmzBxUL82c-KFFgyUQ0MHw@mail.gmail.com>
 <20190218025511.GA15532@paquier.xyz>
 <CAEepm=3ZqWB0csmLx+mYeUa1DDjaTt5k5hA2=3mcGMG2aCoASQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IDYEmSnFhs3mNXr+"
Content-Disposition: inline
In-Reply-To: 
 <CAEepm=3ZqWB0csmLx+mYeUa1DDjaTt5k5hA2=3mcGMG2aCoASQ@mail.gmail.com>
Precedence: bulk


--IDYEmSnFhs3mNXr+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 18, 2019 at 04:10:58PM +1300, Thomas Munro wrote:
> Well the theory is that it's OK because it's only for directories (the
> same case in which case we already tolerate EBADF (for an OS that
> nobody documented so we don't really know if/when we can take it
> out)).  But I agree with you that the patch does not spark joy.

If I would vote for this patch, that would be -0.1, meaning that I am
not strongly opposed to it, but I don't see any strong point either to
do something about it as there are downsides.  When in doubt about a
back-patch, I use as basic rule to never back-patch so as we are sure
that users avoid any surprises and keep relying on the existing
design.
--
Michael

--IDYEmSnFhs3mNXr+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxqJmsACgkQnvQgOdby
QH3iQA//fL/3wJp/G4EebCpLejJmW9pUyVjOEql65eV47VOCLvvHaLeBGXSODOVt
TDuQLCH7KZPeEC4UiG2cOvCUpb8AmZRP47gfuPVpSMJGO8c+6dikMWDdhSWRlorM
BGjjjM87Bz8FBFCbGpw8zYKqBG76XWyFHIXka+x+qsQNf5pIJavwE8nJvFAdL1Xv
nrzImaXgowmPP8iPRH3Yv9dDFqYQjuuqrSK/zCjG1DRmvNVPIhUlJ6b8qYdinssc
n4ceD6XU5D+PBgQ6M0viuXYGs/s38SSlNrECfW51YZvKM/AxPou1C5e71O6a0vDN
7jJysr8+B993/7uuaBVE1qSDTimLU2KCA9OSOAFkqIQxMIGAO9Nwc5pzKiR0vC35
DWAQEiyxQ94HyZMz+90AfsAJGDdJbHTBVT/F/bd0XVB80pNXlEtJjw/TElPBQfIw
nqERiJzUDNwkhwv60MVKsKQfKWz5dBsbdKwj3sfvNE4hsvkIi5Xjr06PbstLH/ib
yMj8xKZWrLZ2Pd0ow0DI+duZ8/H5gUDp/cTAopLhLitqNgYuGi94h5Qqi5MMRFVq
gYdo7n1SaJcjuDT+VOiCLmWKgkZUuAUAWEBnQBxahroakXLZwvNaSgholZa5g4L3
5ii4fJb0vyPw04tHJZa/a3kvUN29Wimqp2tiSFY3nnh0IpwKXO0=
=GO1d
-----END PGP SIGNATURE-----

--IDYEmSnFhs3mNXr+--