Date: Mon, 18 Feb 2019 12:36:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ramanarayana <raam.soft@gmail.com>
Cc: Hugh Ranalli <hugh@whtc.ca>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical
 characters
Message-ID: <20190218033648.GE15532@paquier.xyz>
References: <15548-cef1b3f8de190d4f@postgresql.org>
 <CAEepm=2qfx8Q9PEq3H5KJ74a6RDgpsaJf0kK+PyGEBneC0Sr1g@mail.gmail.com>
 <154982918542.11785.1374991294537224097.pgcf@coridan.postgresql.org>
 <CAAhbUMODj1cCHjCpZ-=kxJxnVWyTsqu6ZnWe8+gCsb5SGnv=zA@mail.gmail.com>
 <CAKm4Xs7CBuCW_XQtrVX6ThwSMiL0WK7Cj3nZx2Jymb9eJ=YdMQ@mail.gmail.com>
 <CAAhbUMOieimkZrCjpw2vQJ-k3p_jzzNsimdi0aq7dwTvKy2isA@mail.gmail.com>
 <CAKm4Xs6JrgX-fb-WpNMMJSz1kAp3HP8N7wnUKbU3ZHW7eHoG4A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XuV1QlJbYrcVoo+x"
Content-Disposition: inline
In-Reply-To: 
 <CAKm4Xs6JrgX-fb-WpNMMJSz1kAp3HP8N7wnUKbU3ZHW7eHoG4A@mail.gmail.com>
Precedence: bulk


--XuV1QlJbYrcVoo+x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Feb 17, 2019 at 12:45:39PM +0530, Ramanarayana wrote:
> The patch I submitted was tested both in python 2 and 3 and it worked for
> me.The single line of code
> added in the patch runs only in python 3. I dont think it can break
> python2. Would like to see the error you got in python 2   Good to know the
> reported issue  is a valid one in windows.I tested your patch as well and
> it is also working fine.

I can see that the commit fest entry associated to this thread has
been switched back from "committed" to "Needs Review" with Thomas
Munro still associated as committer.  The thing is that we have
already committed all the bits discussed here, so I am switching back
the status as "committed", which reflects the state of the thread.  If
you have a set of fixes for what has been pushed regarding Windows and
Python 2/3 capabilities, I would suggest to create a new entry with
yourself as the author.  Spawning a new thread would be also nice so
as you attract the correct audience, this thread about initially
diacritical character support for unaccent has been used more than
enough now.

Python 2/3 support for this script is easy enough to check on Linux,
and now you are adding Windows in the mix...

Thanks,
--
Michael

--XuV1QlJbYrcVoo+x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxqKFAACgkQnvQgOdby
QH3ueRAAnhMezY1KbTxpxi+u6Tivhq0IGInLRWLvp1htA4+B4ZQW+ERpKwBUS1Ig
jtyIPBWa0VBIhTxDzAJ+Q7bCf4PAFEFpxnYK92s74jG03sOemEvcLHAmknM6+jtG
B1cF3jTjsHoCn+4wV+GRw9gQu6IKAmakOBGWkZu9Xy07PDFkd26mqN+STKnU64hC
Mlb8pjVqLS1x4TfAiHeIZWL5knh5sOJf+W7B3nZ5fvrhdRKduIRiGGDBNGFMIGDJ
l0XQZIoRPN19KFASFFVTAaWhZ8TapciKKlCpu94LI8oHFcAQJhXagfAOUnJA2cAg
lPdJ6LsamU0nzam7O06zZFHOXbRbUIW4Mg3e8mvFaoyefQQ5Gk974B95oMZuAvOJ
gtHM9VJsy/obQJHGIPKyu+jwb2KDWODtNLWmR+HpsNjlGx/fK4lyWqHQK18c5ovk
ntBHIyHTUufHL8DOnoKGHsN5X3vAMC3j8KZWAiiRwT0VU5Dj2DbmbDhegYj8oWuJ
pK9QqDEjCCGHs57V8QulvFEQRyOgfMBt6cqVH2cHbnZ5t6CpivzMJow0OdPDly/A
S8hBLl/KAuS2uWIjFgbmxQUWNPd8/Uh6D8zv8gISGYaOPAxPg3+sJUg5gEOhsE+o
+/PuCOXDuQnLIdHs13oyYu8bJymmmeZtwpz+Yajt7DtGCxZyT1c=
=EXfI
-----END PGP SIGNATURE-----

--XuV1QlJbYrcVoo+x--