Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzB4p-0002Km-8V for pgsql-bugs@arkaria.postgresql.org; Thu, 28 Feb 2019 02:05:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gzB4n-0004YF-Nf for pgsql-bugs@arkaria.postgresql.org; Thu, 28 Feb 2019 02:05:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzB4n-0004Y3-Gp for pgsql-bugs@lists.postgresql.org; Thu, 28 Feb 2019 02:05:33 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzB4g-0001mG-FG for pgsql-bugs@lists.postgresql.org; Thu, 28 Feb 2019 02:05:33 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0B9FE23B4D; Wed, 27 Feb 2019 21:05:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 27 Feb 2019 21:05:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=lrBP29HIQ8TOagrgfEt3vwgq/w7 Q95DR5dleA4IzVx8=; b=tgTe21BMxVeIbQ4ausEF0EulynaxxwxGHggQmLvz4K3 iXQTG4rcqTsuVZ+epaoTnLuIS/KS9pD3ZedJdT0pF8qYTzldoxAEKK46bdLCIGPE JJcM9kSWmQTnUNldWDziv0gWgz/vGLEm2FLgHTQvHlxPbn6QdtqLw5qMh2Cff6el hPgsrSQMdA9V68zLpgJwZd4no958t+9Gub4biDlTyBtfsZxV5o6gNGcKT27VcW/u F4qyA3NkyOqdWnIMKeAqieL2V1EX4xsvXPsGT9u2dhh4flYGFvlqX3uf/+FCC6qF /+n7Cv+4gebwxguoNWoLdsVFewWoTjKa6z1gxvx+wAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=lrBP29 HIQ8TOagrgfEt3vwgq/w7Q95DR5dleA4IzVx8=; b=0eMuH+t7XEAARxXDqO2Ws1 vcWvGml0/AG2cJpmnt7HCPhwG4jJhAwTZRkBR8G+w9R4hrKLJyl1IYLuof5ZBOCr Y8htPejHjMQp8BP7PZ6is2a+up2UTxCkTLN+5TeVR4HHHEENJIu6mArsP3GISxxL MyEqb3ryXtGe9aodj+pe8iIBPGh1Kijo8sfFCFmYoZgB4sjq2ntx8IF4a58ssrXa YsQDQ165uM1ae+pez1n9Nxl8tHscklNFT1RTCI8X87sBQ1DxAws6AimJEQlU8jF0 cF62c6qDGjjC188WrOunx2yMwbPdw/BX0aZVV/sGduL6gyOkoOlqDs0ntCCyKcIg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvddvgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvf fukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhi vghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecukfhppeeiuddrvdduhe drudefjedrudeivdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgr qhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 43E3210312; Wed, 27 Feb 2019 21:05:22 -0500 (EST) Date: Thu, 28 Feb 2019 11:05:19 +0900 From: Michael Paquier To: thomas.poty@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15659: missing comment "change requires restart" in postgresql.conf for parameter "data_sync_retry" Message-ID: <20190228020519.GE1617@paquier.xyz> References: <15659-0cd812f13027a2d8@postgresql.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z0eOaCaDLjvTGF2l" Content-Disposition: inline In-Reply-To: <15659-0cd812f13027a2d8@postgresql.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --z0eOaCaDLjvTGF2l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 27, 2019 at 07:24:39AM +0000, PG Bug reporting form wrote: > In postgresql.conf, the mention of a required restart is missing for > "data_sync_retry" parameter : > - in the $PGDATA/postgresql.conf after an initdb > - in /usr/pgsql-10/share/postgresql.conf.sample You are right. I have noticed at the same time that the docs are forgetting to mention the same and that the 80-character-limit was not really respected, so fixed the whole and committed. There are other places where that limit is not respected in postgresql.conf.sample, particularly for the new recovery parameters... But well... Thanks for the report! -- Michael --z0eOaCaDLjvTGF2l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlx3Qd8ACgkQnvQgOdby QH0YIQ//bqWEck2onpmzDyO19cp2u5B68TDyerLdrQwh16r/RdgH8n/C1s883iCc 0Xd7PGD0TaZu3SpXfKFcsbLbI9AH/ZVOAnUXBJvNKAm09veY0+nTWfCTaLwgeLMN +E0fqIt+MxZyEP9NUFDJi2snSKN+E2L4q0QL7FBKCssZuq52MkiHJkEHCKJRtBXg wUC+9q9DjFFjwN2WzcK9lfX1uK11uUrD5ooOlZ8lBfe1AQXDrHuG9dRLFtDVGh8c UgJf2RA6mMzFZpORvAXDVrVLhC80jIvvpYV32OoevZZdrEG/jVjywxAPiGoLfT8L NDcDzIUZGXmFtP+9DDEbkgx5OwQqDhyAqjOCZX1fxZMzUthtqA76pfu5Bg1mQhaf a2wm3fEToAFAnHY+ga9rkhEtfxc4opt+Z6Fe6Qp7UNDAxQn2+43GNKO63nsMdgqb KVNuXcoqWU3vOlgGpxpV4/tjT9+DTnBt6QqVFn6I4IUeroo67hdm4SvepLgZh3vX ie/TLzXukBxhW9eXpaNtqZpF1Egcg7btQZfLMBUD61GYgmqqOUj8ExDM6XscXzhX Jr6qojIytA7VOG2t0rxzMP7cKazhrP/e/gwtYf5tOQARJAHQVnmuvALYWel8hME/ KeXOpPAVINCx8XVvp9uakpOWp5pNooCDv4Brcf0qTS63h1htlJU= =oikr -----END PGP SIGNATURE----- --z0eOaCaDLjvTGF2l--