Date: Mon, 18 Mar 2019 13:53:07 -0700
From: Andres Freund <andres@anarazel.de>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Matthias Otterbach <mo@otterbach.eu>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15700: PG 10 vs. 11: Large increase in memory usage when
 selecting BYTEA data (maybe memory leak)
Message-ID: <20190318205307.jvqlnsih2qbrkdus@alap3.anarazel.de>
References: <15700-8c408321a87d56bb@postgresql.org>
 <16717.1552926811@sss.pgh.pa.us>
 <4ef5f38d5710c4d5c289537c588c7335@otterbach.eu>
 <CAMkU=1wW32K8n4ut_7zz+6HH1J068tFtpv5os=eeAgvjiQH8ZQ@mail.gmail.com>
 <CAMkU=1x_XySqXZ-1gCyoaipKLzefQSr1BuaHL12vy_9WKFnjYQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAMkU=1x_XySqXZ-1gCyoaipKLzefQSr1BuaHL12vy_9WKFnjYQ@mail.gmail.com>
Precedence: bulk

Hi,

On 2019-03-18 16:44:02 -0400, Jeff Janes wrote:
> On Mon, Mar 18, 2019 at 2:50 PM Jeff Janes <jeff.janes@gmail.com> wrote:
> 
> >
> > Doing that, I can reproduce the problem, and it seems to be using an
> > implicitly declared cursor (which I have not run into before).
> >
> >
> The culprit is f2dec34e19d3969ddd6.  Also, it doesn't depend on bytea, it
> leaks for text as well.
> 
> I looked at the patch and nothing in jumps out to me as causing a leak.
> 
> commit f2dec34e19d3969ddd616e671fe9a7b968bec812
> Author: Andres Freund <andres@anarazel.de>
> Date:   Wed Oct 11 16:26:35 2017 -0700
> 
>     Use one stringbuffer for all rows printed in printtup.c.

Thanks for figuring that out. On a quick scan I don't see anything
obvious. Let me try this out.

- Andres