Date: Fri, 29 Mar 2019 11:10:50 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: stepya@ukr.net, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15724: Can't create foreign table as partition
Message-ID: <20190329141050.GA22336@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <21389.1553868091@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Mar-29, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > On 2019-Mar-29, PG Bug reporting form wrote:
> >> SQL Error [42809]: ERROR: cannot create index on foreign table "msg_json"
> 
> > Ah, this is because we try to propagate the index to the partition,
> > which appears to be less than desirable.  Maybe this patch fixes it?  I
> > have not tested it, only verified that it compiles.
> 
> Really, what *ought* to happen in such a case is that the FDW gets
> told about the command and has the opportunity to try to do something
> corresponding to making an index.  But that smells like a new feature
> rather than a bug fix.

ENOTIME to get it done for pg12 I suppose (I don't know a thing about
postgres_fdw or the FDW API layer).

> I'm not sure that just forcing the case to be a no-op is wise.
> What if the index is supposed to be UNIQUE?

Hmm, good point, that should be disallowed too.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services