Date: Mon, 8 Apr 2019 16:39:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: cyberdemn@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;
Message-ID: <20190408073903.GJ2712@paquier.xyz>
References: <15734-2daa8761eeed8e20@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fUvfsPTz/SzOZDdw"
Content-Disposition: inline
In-Reply-To: <15734-2daa8761eeed8e20@postgresql.org>
Precedence: bulk


--fUvfsPTz/SzOZDdw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 04, 2019 at 07:54:19AM +0000, PG Bug reporting form wrote:
> I don't think that such a crash is expected behavior. Either it should
> return the table with all settings or report simply error out with message
> 'unrecognized configuration parameter "ALL"'.

No, it's not correct to just disallow ALL as we have a similar check
in GetConfigOptionByName() for individual parameters.

Problem is origically from 25fff40, and got worse as of 0c8910a0.  A
superuser is able to get the list of parameters, but I can easily see
the failure when using a plain replication user.  A replication user
is one which can take a full base backup, so he can easily retrieve
the full list of parameters anyway.  What about bypassing the problem
and just allow WAL sender contexts to always have access to parameter
values?  I don't think that this is much a security issue if one
thinks about the access to BASE_BACKUP.
--
Michael

--fUvfsPTz/SzOZDdw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyq+pcACgkQnvQgOdby
QH1meg/+IAk6C3fu7TYRsNiLzCZ7WVRH4VlZpwW0C2HFEcm5zC0PsFtNqeFDhG2e
RAZcNnBQEa8mshf3dPIbeLeSO6dS/eBrHdM4S8otU3op27EC5gfLeeRtlLy5WUkK
c4fJMRfVlTAFATrQm77XJGBgpoc0eIlND3smKqyDOwBcwgRvft5cTnz1yqc/fLDY
vw7v+Nso5hcZDDQmlmnspuvtjLqzlHMpuGrY18rhFSZsdDVJTzs6TU3N8ACkc+M0
0EnnLAz9u1u6ST4eiA2ncj5CHGVp92of2GgX58UNfcufi/XOlFSSvlyvHTHOfJcL
fHbJlyCO81erHnepRENrnR7t1N0GbpLO9qpeJl7ggJiU30+R2RFqUWq/lOtbGVTF
QT6QcftujoYcOFiGgQEkkMxLlvYg3ejJmXw/Rbyy8sPEwe6jPmIKlYjydyuC5Afz
mQzZXfbKgb81+8leoKedB/udfQGfWVXUN+OQ2WRYFN6fV4u7u30xhcy2k/HuQkAV
TYNSdGuf8mDuz5EXw1DjqCZRl/cuSH2XBaJzxxsV7UH3Ez00M8Xi9Mdik9L+/FlT
Kghp0ub49dwYlAAb5o/ga/6Ww3L/CrY1c6g2AEcuYCkG8BP1Gd+PoyXrtJB9f15F
LY/yjbPO9TGudMp3rp6F4tBg2i3qshFZNj9AmsiAvZPdDHE3gLY=
=dzOW
-----END PGP SIGNATURE-----

--fUvfsPTz/SzOZDdw--