Date: Mon, 15 Apr 2019 12:39:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: cyberdemn@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;
Message-ID: <20190415033906.GA3526@paquier.xyz>
References: <20190410060427.GB2728@paquier.xyz>
 <20190410150121.GA26340@alvherre.pgsql>
 <20190411030712.GH2728@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="d6Gm4EdcadzBjdND"
Content-Disposition: inline
In-Reply-To: <20190411030712.GH2728@paquier.xyz>
Precedence: bulk


--d6Gm4EdcadzBjdND
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 11, 2019 at 12:07:12PM +0900, Michael Paquier wrote:
> What do you think about the set attached?  I prefer that we use
> psql(on_error_die => 1) so as in the case of a crash or an error the
> test dies hard and fast. In consequence, I have granted
> pg_read_all_settings to the replication user to ensure that no errors
> happen, still the syscache lookup is done.  We could have negative
> tests but I don't think that's worth the addition as we already have
> tests for pg_read_all_settings in src/test/regress/.  If I remove the
> patched patch from walsender.c, the test fails immediately.

I have done another round of review of this patch and committed it
down to v10.  When testing on Windows, I have noticed that these new
regression tests suffer the same problem with SSPI authentication as
the recent tweaks I have done for pg_rewind.  So I have backpatched
the extension for PostgresNode::init done in d9f543e9 to be able to
add extra options for the authentication configuration so as the new
tests are able to work.

Thanks Alexander for the report!
--
Michael

--d6Gm4EdcadzBjdND
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyz/NoACgkQnvQgOdby
QH2Chw//Uq8iVvdHg4+uHVC/qHQ67I2HclYOqXyzQ3p9Yo1X6EnRHvtt5sbRW2Dy
CpcJDuzKMqpDeA8AhwWrQv2oLPGvz+KmumlctQMyO56RKMLKLxUOCdK30GdgzMNz
gHdP1v8XLsAetFcQZZe4zk3yLI62nJXL50DZx5bjIMLs0btUE0Q/OUpFLZzUPvMT
R7QezKU3oMxUO1YNDdqh8fVsSNrsluDa+6cZEMFZlGpd9nPz3yF9Orl9rgptZmO7
4I8ZUkxmDNEXIN9YTbkQa4QNcd3nPlwobI18HP25fnDSwBupDIY52ayXB26G1IZc
Qls0Uak8toX037wzKPu3YZ/yA2ev0Ij+5rBL+W15oHvBM7Gz+aNlqxHHvTijDWW+
5kI0Wmct9bl4T6jh3n+X4r4rOISc9lqwNd0YNi8+ldNmOqjC7nDj+gCDIhxW9YzL
rvybRseyl1Ne+AyIeYbq1cPpfz4t3qBc3fHO9NqE9gYKvHcnVSWaLgmXLZLivXaT
k29Q1LFzMpGrQcd4lkyu/8DCUrX34su0+aOKUpcM33MuNjXziTtRxuuNkuvMPv5I
TLGqdof+1PMAPlwR+CfKQheQlB56EYyUYL8weZK463X1Igb34UAJpyGnZobPqLBK
F+0UQc4MAWcwnkP3zbSlegANEuV0un4MUNZMQId8bSigTLE2o+U=
=3j9U
-----END PGP SIGNATURE-----

--d6Gm4EdcadzBjdND--