Date: Thu, 16 May 2019 13:36:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>,
	pgsql-bugs@lists.postgresql.org,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: BUG #15804: Assertion failure when using logging_collector with
 EXEC_BACKEND
Message-ID: <20190516043618.GD1415@paquier.xyz>
References: <15804-3721117bf40fb654@postgresql.org>
 <27CD45B5-88F7-4A09-8B31-EFE41FC37FE1@crunchydata.com>
 <26332.1557863524@sss.pgh.pa.us>
 <20190515073125.GA1517@paquier.xyz>
 <4643.1557931189@sss.pgh.pa.us>
 <20190516013808.GA1415@paquier.xyz>
 <20190516021903.GB1415@paquier.xyz>
 <28927.1557977558@sss.pgh.pa.us>
 <20190516035617.GC1415@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Oiv9uiLrevHtW1RS"
Content-Disposition: inline
In-Reply-To: <20190516035617.GC1415@paquier.xyz>
Precedence: bulk


--Oiv9uiLrevHtW1RS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 16, 2019 at 12:56:17PM +0900, Michael Paquier wrote:
> The test is able to pass, but we have a race condition between the
> moment the backend file gets saved and the moment we allow it to be
> read.   I have not spent much time checking the stack between
> InitializeMaxBackends() and RemovePgTempFiles() in postmaster.c, but
> 57431a9 triggers the failure.

Oh, I think I got it.  The issue is that we call RemovePgTempFiles()
after starting the syslogger.  This cannot be run with other processes
running in parallel, and with EXEC_BACKEND there is the extra case
where we have a pgsql_tmp/ at the root of the data folder, so the
syslogger complains on that.  By making RemovePgTempFiles() happen
before starting the syslogger, then the test complains again about the
assertion without my previous patch applied of course.  With the patch
applied, I get no complains.
--
Michael

--Oiv9uiLrevHtW1RS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlzc6MIACgkQnvQgOdby
QH0X8w/+NE7loWLn3sqR8u4Cqs6ztN+dxZv8E6jM+vq13fXSA9Dyk6WoiKVs+Ce6
5SCk8xbEsJJUK6w3RqjruFQy7D7Fk5oI+tO+/RoZqTc5IrR96lQRbst7snMgK2Se
DZXR6j5q4+ujtTYJbG9VvoZVeekZB0mGy3jFV9TDxX4mY1uP3v/P/d1rTCQGD0si
lRE5Tt9bFD0QicX9QRPkIWng9b4DeRp/7C+NwtBTCaHhXkJUUQoLEh9uiv0eMZxr
/tFSrRfqvbTBy0IczcxkYKHrjUbYT4L1iV3HUDXx9L7W7F5TSuIofJII8wGRJ+qK
ihPEKeIGbP7krVGv908YebtOnbhYj1zsFdwn0IPOFUPD9xLVH17WfDRForgjpoPO
t9zSO+fCcRAcA+jDCVi0OOLiRftJww6G+GdJgI4tcCLScXs70GbFZw2L7D3Ozn8z
GOMiypsiVEOAyarLd4TbVlto2Fb0YU9BJJTf4clw33+rJp/9NRlkjZoYcH6qTNwB
4PxrPob/7kllXdo8XRftMoD3WYJ6Rd9l8HTCgSj2Zru/uGR1cHkXImwU+zuUyGwu
GbWh/lnRkjYYnewlrLwi1uOkr2ebg3ND11nF/DZ7VsZmHhkY96SVXe8QRTVYZeAR
zXLZQTl0f3+PKFGDViBg+S8wYA5xnH1TSxFFJ87hnmHvPtLqaHI=
=jiDm
-----END PGP SIGNATURE-----

--Oiv9uiLrevHtW1RS--