Date: Sat, 18 May 2019 18:35:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with
 EXEC_BACKEND
Message-ID: <20190518093522.GA19212@paquier.xyz>
References: <4643.1557931189@sss.pgh.pa.us>
 <20190516013808.GA1415@paquier.xyz>
 <20190516021903.GB1415@paquier.xyz>
 <28927.1557977558@sss.pgh.pa.us>
 <20190516035617.GC1415@paquier.xyz>
 <20190516043618.GD1415@paquier.xyz>
 <31437.1557982294@sss.pgh.pa.us>
 <20190516060628.GE1415@paquier.xyz>
 <20190517042536.GM20887@paquier.xyz>
 <20190517202443.gw4zdfkpwgsjdel6@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI"
Content-Disposition: inline
In-Reply-To: <20190517202443.gw4zdfkpwgsjdel6@alap3.anarazel.de>
Precedence: bulk


--oyUTqETQ0mS9luUI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 17, 2019 at 01:24:43PM -0700, Andres Freund wrote:
> I don't think a windows-only patch is the same thing as a feature, one
> that makes debugging easier to boot, that's applicable to all
> platforms.

We are discussing here a set of problems which breaks the logging
collector to work on Windows, requiring mostly a Windows patch.  And I
am not much willing to mess up with the area of shared memory handling
on Windows a couple of days before a beta.

>> diff --git a/src/tools/msvc/config_default.pl b/src/tools/msvc/config_de=
fault.pl
>> @@ -17,7 +17,7 @@ our $config =3D {
>>  	gss       =3D> undef,    # --with-gssapi=3D<path>
>>  	icu       =3D> undef,    # --with-icu=3D<path>
>>  	nls       =3D> undef,    # --enable-nls=3D<path>
>> -	tap_tests =3D> undef,    # --enable-tap-tests
>> +	tap_tests =3D> 1,    # --enable-tap-tests
>>  	tcl       =3D> undef,    # --with-tcl=3D<path>
>>  	perl      =3D> undef,    # --with-perl
>>  	python    =3D> undef,    # --with-python=3D<path>
>=20
> Hm? Is this to coerce cfbot?

This is part of the patch only because it has proved to be useful for
testing with MSVC on my VMs.  I am not suggesting to add that in this
patch if this gets merged into HEAD.  It is actually a good idea to
enforce that sometimes for the cfbot..  I'll remember your suggestion
for future patches.
--
Michael

--oyUTqETQ0mS9luUI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlzf0doACgkQnvQgOdby
QH1fkA//U9u1DzSavnwxVD49rs0VTWsukWcCV0fiaW5Y9WgF4UlUV60ml58UsGbA
/6MPdg5inwOymjayfZ5zMm6V7VCyZpMvkpaMj4Yp1PYD9bLwsHasULlzjWlfzTqM
XGDiBvBhHBi4V/wUNzTVTyktKaye06k+xPI1CT78/OKe/uSTBWmYkhbM3kyX+vVz
XFSs/tkwPjazXhW0LGqdmsark3qKRjqjTFFv3OwDsEzwaw9tY3GE8GV5IrYToBX/
/ctXAFWrApSRGpanZLi5jgpTjfJGWmPiosk6JRu7e59DtnyyMX+7EK3WeZY4vLHN
NrzqccrObghDbbt3ky0B9fGxFug4Zxg+u++kNKVn6cBT++0TAlrTymBRKTCmN3bY
D/ZwdjFnHrLluTXTBjvwgJzL33fAN4PkaACGJizoed7TzerPpNJFOnwPg4aVEZcw
2VGmtNLmIXGyWjgy9114caV6efB4O1JaU9HsEs/ezIcEBC67JN4qIaA12nwxcaNy
1o/60aLcHjpKzGGYXf6LDuOVSDHIEw0TrSBSNVstcR7+2Mc0qMwdl26Uo159AT5J
AoFFHYulvTIVMP0LQ1nzj/PFQm0g/gCL2FkoWCCT7AttzqWO8Eg3H04D7WKUQqWD
NrC/9qd1dZP/zi0+Z5rhPGIE0Oc2wZBDRN9EPNpaeigb0CrR714=
=VY+0
-----END PGP SIGNATURE-----

--oyUTqETQ0mS9luUI--