Date: Sun, 19 May 2019 09:43:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with
 EXEC_BACKEND
Message-ID: <20190519004344.GA3653@paquier.xyz>
References: <20190516021903.GB1415@paquier.xyz>
 <28927.1557977558@sss.pgh.pa.us>
 <20190516035617.GC1415@paquier.xyz>
 <20190516043618.GD1415@paquier.xyz>
 <31437.1557982294@sss.pgh.pa.us>
 <20190516060628.GE1415@paquier.xyz>
 <20190517042536.GM20887@paquier.xyz>
 <20190517202443.gw4zdfkpwgsjdel6@alap3.anarazel.de>
 <20190518093522.GA19212@paquier.xyz>
 <28565.1558196308@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU"
Content-Disposition: inline
In-Reply-To: <28565.1558196308@sss.pgh.pa.us>
Precedence: bulk


--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, May 18, 2019 at 12:18:28PM -0400, Tom Lane wrote:
> At this point I agree with Michael that reverting 57431a911 is the most
> prudent thing to do for beta1.  While it's probably not *that* hard to
> fix, it will require Windows-specific testing.  Moreover, the fact that
> there are race conditions involved means that one person's testing might
> not catch everything.  So I do not think we have enough time to get a
> trustworthy fix in place by Monday.  And we do have other things to
> worry about.

Thanks for confirming.  There is little time for doing the revert, and
it would have been nice seeing comments from Peter.  Anyway, I should
be able to do that myself in 24 hours or so after coming back in
front of my desk so as the buildfarm can have a couple of cycles for
its work.  If you prefer doing that yourself, that's of course fine by
me.

> I wouldn't be totally opposed to un-reverting after beta1, if a
> better-tested patch emerges.  But we don't have such a patch today
> and I don't see how we'll get there this weekend.

Possible.  My recommendation is to keep this as potential v13 work and
focus on v12 stability.  I have no doubt that after beta1 emerges we
will get enough reports to work on.
--
Michael

--EeQfGwPcQSOJBaQU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlzgpsAACgkQnvQgOdby
QH0SWg//bunLBdlRR7znDN9XDNCrNCoHF+bV2BxQtGRx+rhrT4sZKYV/XCnUVGyZ
+R6QrJlbuda7ovZPGu4qxWCDyFSDPzfB+899r/iEwYgxhYR/UEVP8Kml40NafGdF
4XIHRD565fFZy1k5gvaH2MYJ/NeuE/6eWS64iwLKtRMNRy61VNLYgUOBwHavZ8Fm
ijfYOoUeQCdD3hgbD6rM9apYC6ExuEPKesWXCIKaDGuVtDfWo2upew7Od93nd4a5
olrGghTtI+585sD59Fmp6S+n0XRQXU+1FgpkckNRzEKhy1l1oW2tFKVYci07QRmQ
qvuzzMB6w1E20SLWd5ROkDPaSCgiOqORjxsByy6mpwYPX0n7aFkhvypCHndHaRx/
9Xn/iC8j0SC4CwmiSFYf2Facii8eSV1JmoEMqMhGyC0BmLDEp9u6Z97AfUyFmf9d
sE3LHQHVTWz+0dsSS1Jvqk41ukjE5d17y+l/jBSGDAEKU/NSNP52XjaaitS6IrYr
R2gC8+yd3M369cDYTpQwpgwxVc34tOyBltGB+qnX4DjTwm2m4UY88JuHbP0VY7Uo
jPbbKK0/0V3OUjYLep7KGa/OBjkJIvzmdi4nn5mQLGjP8rrxWA/m9Ooa5PwCqbAm
u+64rmNwhfZLW3faoNCJnTjocdEWJTTsqPrK6xUwifs2CnUh1/c=
=pwc1
-----END PGP SIGNATURE-----

--EeQfGwPcQSOJBaQU--