Date: Fri, 7 Jun 2019 14:42:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: clemens@ladisch.de, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15833: defining a comment on a domain constraint fails with
 wrong OID
Message-ID: <20190607054233.GG1736@paquier.xyz>
References: <15833-808e11904835d26f@postgresql.org>
 <20190605181502.GA10753@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="CNfT9TXqV7nd4cfk"
Content-Disposition: inline
In-Reply-To: <20190605181502.GA10753@alvherre.pgsql>
Precedence: bulk


--CNfT9TXqV7nd4cfk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 05, 2019 at 02:15:02PM -0400, Alvaro Herrera wrote:
> Confirmed.  It works for superusers, which explains why the existing
> regression tests pass -- and that's because check_object_ownership()
> (which is handing the OBJECT_DOMCONSTRAINT case wrongly) is bypassed for
> superusers.  Annoyingly, get_object_address does not return the type's
> OID, only the domain's.

Well, it wouldn't be a problem to do a syscache lookup and then use
the type from contypid, no?  It seems to me that it would be more
consistent to just add a pg_domain_constraint_ownercheck() in aclchk.c
as all the syscache lookups happen their for all the other objects
types.  What do you think?
--
Michael

--CNfT9TXqV7nd4cfk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlz5+UkACgkQnvQgOdby
QH3gTxAAoM1wd+Kj+33fBns4nmP8hpwkcbF5Toh4jnSU0/MdHWOhqMPkTeAJJt5J
J7g3tc7LF6tjLiEfN/w4tCGYu4/ub6ZOI418tzQaGF9TCCmLA5xZFS/OkuL4TS1Y
1Ka2/PHcxhZYTAcqJJHDmkjqpzVxRQCHo8qvz5d44OdTEDqUhS5DVWHsMBnvTLe7
gvTqcx7ORdnnIDQVreSYruk60xhYXCQEu12hxD6rAoUdmMFaNSxZbdD+McrBje7J
WXc2epO3WaMWPOZpFP401jVyvVFbbYp5K9TgiyxmtIOZ60B9Berdv/jg2YXnX/7T
OTR5xAfXRiPgkyiJuOzzWsImBL8ML79rOMy+XkR2npoQ6DKfgZpflJoImGILIsFQ
Hxxr4plUWb0dCi2wuH7Lc9m+VqkR2dhQt1qmyrdx+8/5VZqK9mIvKtgMJBjc8tRD
vRHJu7MCmp9hPFsfmENxuWLUMY9smgjVFYL+hywNuF3AhulFjB81Z3tx+5Z7nT2C
mx6zPWZBPDzsavHE+mZwYJN48PXjT2KLWtgsZ/EzT/mpJjQbajBMYaswwuk8Nb42
VRTRWgWC97WhmGc+EhPiGDrh76uDZ8Rstdhcj3lzXDXRD5ZxKFp3tyI4v/ntt4fF
az93BRdgWpzwFzT5OG4caykTQ7U9a2wwe0R+J45vxpWJCfxb3tw=
=FLcG
-----END PGP SIGNATURE-----

--CNfT9TXqV7nd4cfk--