Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hat8N-0003wX-DS for pgsql-bugs@arkaria.postgresql.org; Wed, 12 Jun 2019 02:37:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hat8M-0003vt-8H for pgsql-bugs@arkaria.postgresql.org; Wed, 12 Jun 2019 02:37:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hat8L-0003vB-Sw for pgsql-bugs@lists.postgresql.org; Wed, 12 Jun 2019 02:37:06 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hat8I-00015w-Ah for pgsql-bugs@lists.postgresql.org; Wed, 12 Jun 2019 02:37:04 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 77DAF22303; Tue, 11 Jun 2019 22:37:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 11 Jun 2019 22:37:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=epur3Z0aXMCwJCvK1qV2iGkdC0L uUJdTxtfCCA0rp1I=; b=WaIu9tTWdKExCeoIgvlyPSxagBdhoPS3vylEsLqZQLK I7oUBWU7FgWzwAU5vGS2F86u6j+flb1keIKZSiwxg7sO4d30D+NLHxkB0BCKv/Xm VDOoK9hHt02uxBUZAUgS2OT5eAdnhLuGhObOVEPI2FU9MzfBb5BCplv0RUAH2vBy noVoVyolRUtvAOf5SNjVpTt/4WvxcOAAXVza77VhfGv1VCGuK5EgALaZWx519uBX MuYHAOf8edxB46Avv2h8QDxANz6aYl2OYZ+3s4AQX9OcA8i8LhgSwpwiyssMkI8e SZxd/YO4cvBTO5GlZJdV58BtCobYKBd7YCK2EdJytFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=epur3Z 0aXMCwJCvK1qV2iGkdC0LuUJdTxtfCCA0rp1I=; b=m3d00D2wh68zIhjXM6jOLc ur4nKJ/7jmgXQtEJQ+K+fumciuqdRK5JAstroM704/mOXuKa2Zp9WECV6Tze3A+g +kwVPTAKssAYEaadmWcsyw+jwjJhTIQTMH1ueW4T+0rYUqkQT/YknaqiVvPk19mc 3TsY6Cz6qDBMpL8EmPEiirhLPtAbYOfgl9qXLptVdHXUZUTuvIXV7g97vgxXH6eQ iOTMajMjZhfqStr4URssxCgcEa40+keM+dPIUJcJwVtH6C3ThIAxeoJcBSLccgbl G6bVbxMQtUswihdJjr5FV9C4mNHO+jAiC17oGGFO2HU1fEsbkdPnFlhbalt2zv3w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehiedgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepudduuddruddtvddrudektddrudekheenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id DE7AC380089; Tue, 11 Jun 2019 22:36:58 -0400 (EDT) Date: Wed, 12 Jun 2019 11:36:56 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Daniel Gustafsson , clemens@ladisch.de, PostgreSQL mailing lists Subject: Re: BUG #15833: defining a comment on a domain constraint fails with wrong OID Message-ID: <20190612023656.GA1745@paquier.xyz> References: <20190611045539.GB2132@paquier.xyz> <20190611133255.GA13589@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline In-Reply-To: <20190611133255.GA13589@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2019 at 09:32:55AM -0400, Alvaro Herrera wrote: > Yeah, looks better. I think the error message should be a normal elog() > cache failure, though ... at least in the COMMENT case, the obj-does-not- > exist message is supposed to be thrown by get_object_address(), before > check_object_ownership is called. >=20 > As a matter of style, I would get rid of the 'conoid' variable and just > use address.objectId where needed. OK. I have included both your comments, and committed the patch down to 9.5 where it applies. Thanks for the feedback! s/unathorized/unauthorized/ by the way. -- Michael --W/nzBZO5zC0uMSeA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0AZUgACgkQnvQgOdby QH135Q/+IHvbkH7U2C1S1pcZouj+h6qNR+2sQ3Xml4IJcoC58/DYkaJ11Hpqs7qi Fj7t5zGqlBFF1gxiSL+bD8ghhLI8TY0XZ+p6HUzyrCcv9dg4McXjaDqoWz/9BI3w mJqBxov7dvDG1ng2D6QI+Iwu+j3ArSExEasmnnqUi+FYNVIUzFCsH2WW4BEZfeUJ cf+ZOl0sg8yMGd2WZrX8PlNShzV1B6/BtONpC8603wQhRdWCTWWBhhcXt0K+mi4i Q/X+JJUW0L4KyvaJaSGYt/1dRGZzb/YJg4lqcas/qqnwVxVuZ6cFOU7UI8JZ+z5g 7U8yQUTbVIUNa8iCNCF9Cru2j74hhAcFx0GdnrxoCl0oNDK84VKapgfQy9l/3Nsa dcuq+2TWk1zTuf2PSZUv2ldLZckT37LFbII1zgLHySU8QNJvkKGN5/Ybk3sRAuhZ c6zw3JsZuXNFT/8T98+VmQDbWOhFI8IomLCJ4PPNVm/iFEvDALFndxcBh+24Btec k0ReLcSTsziXZ7BX10llpY8uisU22y7/7wKVTZxJkPvh20H2lIzA52yUAFt/pu/1 MWwCziJwHT+2SekVxCKpjbZezZ3AczcLKJsX2KozMMeH7o3lrShQA7Y95QB/TgSq D6LtDX2VO++k7X9W202h09wjIU5Z+9EvBG357aIZGaoyTjnjMq8= =byCS -----END PGP SIGNATURE----- --W/nzBZO5zC0uMSeA--