Date: Thu, 20 Jun 2019 12:12:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jorge Gustavo Rocha <jgr@geomaster.pt>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15827: Unable to connect on Windows using pg_services.conf
 using Python psycopg2
Message-ID: <20190620031218.GC2660@paquier.xyz>
References: <15827-e6ba53a3a7ed543c@postgresql.org>
 <82491.1559409563@sss.pgh.pa.us>
 <e12a23c6-5e00-3fa6-6179-681336130361@geomaster.pt>
 <1473.1560866085@sss.pgh.pa.us>
 <fcb5c34c-cf5f-6dc9-c68e-6b297f073b79@geomaster.pt>
 <CA+mi_8aBnLKypX2Ttksg8JEhApBo=JpF6P_STQGp-FOvDpn6Yw@mail.gmail.com>
 <81d9d421-6947-7111-a1dc-cfd99cd3ae53@geomaster.pt>
 <23215.1560977098@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="adJ1OR3c6QgCpb/j"
Content-Disposition: inline
In-Reply-To: <23215.1560977098@sss.pgh.pa.us>
Precedence: bulk


--adJ1OR3c6QgCpb/j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 19, 2019 at 04:44:58PM -0400, Tom Lane wrote:
> Ah-hah!  That explains much.  So a non-invasive fix would be to force
> parseServiceFile to open the file in text mode; I think this would
> work for that:
>=20
> -	f =3D fopen(serviceFile, "r");
> +	f =3D fopen(serviceFile, "rt");
>=20
> I don't think that that's really a good solution, because it does little
> to prevent the same problem from reappearing elsewhere.  But if we wanted
> the smallest possible fix that might do.

Actually I think that something like 40cfe86 may be a solution to look
at (combined with 0ba06e0 except for the portions enforcing the text
flags like in initdb).  This stuff found its way only in 12~, but
having us switching to the concurrent-safe version for fopen() that we
bundle in port/ has the advantage to take care of this issue, because
on HEAD, if 'b' or 't' are not defined, then we enforce to text mode.
Still back-patching that is sensitive and we have known that hard last
year..

The discussion here is on 10, and the password file has does not
enforce the flag either because it filters '\r' by itself.  So another
solution may be to do the same thing as what's done in
passwordFromFile()?
--
Michael

--adJ1OR3c6QgCpb/j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0K+ZIACgkQnvQgOdby
QH26dw/9GidkGz9MMlkUpT0WUJU9ZKRRnvFmVg9Pkxs96sc+ggRGeBPIZw2mEaoi
uZuP5OaZ+5bZNtOhicyMY3o5gLCfK21Ob42hLNWfOlsDcy7v7CR0HDfEAm6aYfqg
SEDDCo+nTf/XefjPHqgzB47I1p7SmE87K+aInEMda5CZLD6vJLQNlAuDh0VJ6tkL
efYcPbjGXLhdsLWPBYuPLd8EHU4IK2oB3pMrKNdN1w35koEHehpJJnthOKT3L+mg
3AJbDv9SeL+FXkrMvbcc9CQdEU+mDZ9ki0XU82GR39E2CQIGJUxjsj1dc6BVrSim
OdpR7s5dwr2hkLhv3dz9O3voCx1r3xHjQjg4bryzgeFu7VhEooXseAWk1mDnEsgF
1yP4UfMkrj6pUbOi2i6UhuSLwNSSYUTAT6L/mRJONa3yLgRAtWnNOakfoYJvIEje
iGf4IYFzhpjp7CQz08C/iIWWU7iRfMul71Uf+dR97nsgP5di8Q8AZ34II9FNTSdm
GkkImLxgjkUo0HXouyzIWD6aDpXoNE6g+eHhUEc/jkvg5X6G1dDkJqYdS4cS6+qN
oF7JhsTLZH8q3oKZn2HiAOaDpN2NddWx6iZuA+POF5yMAx2BTnCPK0Azfb0/R3U/
3yrl739ZoaOl4IHIBrQ4be3AwrrBBNlfU7If5qizSH1BMlwbhEo=
=b5Sb
-----END PGP SIGNATURE-----

--adJ1OR3c6QgCpb/j--