Date: Sat, 22 Jun 2019 11:44:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>, serpashk@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on
 Windows with Visual Studio 2017
Message-ID: <20190622024433.GA1713@paquier.xyz>
References: <15789-8fc75dea3c5a17c8@postgresql.org>
 <CAC+AXB1Vw81MzWAPNmvpQhr_dDezucA1xu_JB9-asxzOk0rGYA@mail.gmail.com>
 <20190528105802.GC2682@paquier.xyz>
 <CAC+AXB2gUvPEg_AcCVE-DREP3nECi7bvaaOhre-sZVHj7Khjhw@mail.gmail.com>
 <20190531142832.GQ2848@paquier.xyz>
 <CANFyU977NVQCO_Xu_er76Eezg2D3zVNNmf_d7j5d5iq2T6FLdw@mail.gmail.com>
 <20190603235132.GA1529@paquier.xyz>
 <CAC+AXB3_YNqAr=u9ccuXOoKQF=kZRQFjnLgRaSFQEjNz+Po+1w@mail.gmail.com>
 <20190620024941.GB2660@paquier.xyz>
 <CAC+AXB2gyrRJE+8gPwWTptaMTEH31dzJDsBSTMc3twn56zb=jQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0"
Content-Disposition: inline
In-Reply-To: 
 <CAC+AXB2gyrRJE+8gPwWTptaMTEH31dzJDsBSTMc3twn56zb=jQ@mail.gmail.com>
Precedence: bulk


--k+w/mQv8wyuph6w0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 21, 2019 at 12:23:21PM +0200, Juan Jos=E9 Santamar=EDa Flecha w=
rote:
> Since the third parameter is only currently used with OpenSSL
> libraries, I thought it would be ok to touch it in this patch. The
> reasson behind doing so was to keep the logic for the new fancy
> library naming tidy. Documenting better is not a thing I can argue
> against, xlib stands for expanded library name as used in
> GetAdditionalLinkerDependencies and maybe a comment like this can make
> things clearer:
>=20
> # The parameter $slib is for sufixed run-time library.
> # When available it will be added, if not it silently defaults to $lib.
>  sub AddLibrary

That's a sensible argument.  Perhaps your way of doing is much better
at the end.  I still found the patch hard to follow in the changes it
did though, so documenting things for the changes you are doing would
help anybody looking at this code in the future.=20

> No problem with that. Even more so, it can return 4 values: the 3
> digits and the letter. For example, 1.1.1b would be (1, 1, 1, b).

There are two reasons why we need to know the version of OpenSSL
dynamically:
1) Enforce the correct compilation flags in pg_config.h
2) Select the correct library paths.
OpenSSL keeps API compatibility in their stable branches, so 1. would
not be an issue.  I suspect as well that the installers we use for
Postgres compilation are not going to change their layer in a minor
version update.  So having only 3 digits is enough.  2 likely not.  I
would just keep it at three for now.

Could you send an updated patch?  I would like to look at this stuff
rather sooner than later as OpenSSL 1.0.2 goes EOL in a couple of
months, so there is going to be demand for it.
--
Michael

--k+w/mQv8wyuph6w0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0NlhEACgkQnvQgOdby
QH2kpw/+IjZDePhnMc6AjCRxiaBlG1T+uh6s73zYkOdyvLubT6//7RAaDtpIpAsl
S+++ugmNWTQ3iBYLJkLy4Hm6ghl9u8nBkle2Eae945cc7i0gFVvWUYEtP5KTMxIX
6XmSQ6RYU0KeP8uGeTgDYMMKLpI02jx0rTjEgYsEqhG6SAyI2/fGn7bBOVcBUjtz
H80X+ZfxiDkHI3OtJj+OLGebGNKTG1TpoWzoZgWMZhJicNwGJNyT1KguL5D5zZcY
/zRhselqJYQqQoWyQkJFJOGthyPVZuOrmkY36vDb7RUQK6XIyFGOlPn02Bcxv1Te
ROBRBACL/oCg7nSHTWvsyIWkAllNfHzjLPvVabtMkWrFUbSo3UDmyhyjdAgbzngS
TscgvhJ93LNuUT1SAJ+vMbca7cb79qhkOgOrwNzoyxLkwc9pu4ISVsH2c5IBX6oq
YVcHSAR5Vltq3LFl5LaRHFWKOvKuKI93o689I+DQekly2+TALfVV55TJFJZsXPHi
+4r8wcMtDXjWcERNJVWMx/l+CeJ2/MuZ7at57MfDfhDqRye8jTAsvGkPmyi27eml
NuuljSJ7B7EmClhgdpIsg//TDdsONCng7jktBrZwysoxseU2wSN79HKIOFQaWmzx
GFPs1KzXE7tiqKT9HOAlQmKhNssP/p3ZAY6+d7zXR9VzDvgT8+k=
=0xeF
-----END PGP SIGNATURE-----

--k+w/mQv8wyuph6w0--