Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hfwf4-0004JE-Ck for pgsql-bugs@arkaria.postgresql.org; Wed, 26 Jun 2019 01:23:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hfwf3-0001NT-8g for pgsql-bugs@arkaria.postgresql.org; Wed, 26 Jun 2019 01:23:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hfwf1-0001NM-NS for pgsql-bugs@lists.postgresql.org; Wed, 26 Jun 2019 01:23:45 +0000 Received: from [66.111.4.29] (helo=out5-smtp.messagingengine.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hfwet-0001RZ-Bv for pgsql-bugs@lists.postgresql.org; Wed, 26 Jun 2019 01:23:43 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 995CA2067B; Tue, 25 Jun 2019 21:23:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 25 Jun 2019 21:23:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=qbYbmGq7EDsDuIiVhfwWLxkUBmq mfJyxKTG+TfNg4IY=; b=qlRLjDV8wj6zvkf82NwsS2uOdkPtTefSD348XrQLUOC G254w2oMA9jYSL5uV8q7fYZICvu1HNen4Xde7V+8M3woHqpBXo78J3vZBEXiIVaL VDsTDNAAyvK/oxPHO+laWKgzAPb2ZJ59sTU6bPtiW1c9QcpD0OrENrkqMiGCrvz6 QeQKjXtWiikoHdTJgScRk/s7qlFjkSsjSmGFHSeolBApJqg84mKG6oCUz0HO9RdX iSkPDCAqSd/cpg4BjfjqyM1+x26iPhlXpr6p9zmKuOM4EsRDGwg4mXr7HO8FE4oZ bmC8d9F8fSIyhNMzD6VCyUeoQA1xzsj5LXRdAtqy4Ew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=qbYbmG q7EDsDuIiVhfwWLxkUBmqmfJyxKTG+TfNg4IY=; b=u9MUGMtPEF2AEb+K0/f5/+ WtJolBsVLbsc2/dSyS4A7iRJGz90oTyIpAZqA3JemsdPcBpV86BybBL7B8RVGvMm ruseo5dCaQR3qG3G5KLPuxTHqIrQcNz/yYvJDg/aggf2HR9MS2/vNjJ7QYN5+Ahg 5Lsg5Fp0/Z2Co4LCkjayP5P1YENQ9suRIgOqkJJtAQt8UBpHK/twnwlOt7h/lMNy WBQKqNL5TVvhaF9fB0GA9qW6u/1d7IEMuQUWITuDzkEblVmWDJ23va9AZYz4+TM+ VD2TRaevjcmZfkJaH9+Si5xyj/konxMjQL41yukccLqV010e0HVq9be5rIgXo+sQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id B181A380079; Tue, 25 Jun 2019 21:23:04 -0400 (EDT) Date: Wed, 26 Jun 2019 10:22:56 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha , Sandeep Thakkar , serpashk@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on Windows with Visual Studio 2017 Message-ID: <20190626012256.GA1714@paquier.xyz> References: <20190625080811.GF5569@paquier.xyz> <20190625135243.GA29893@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <20190625135243.GA29893@alvherre.pgsql> X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.29 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 25, 2019 at 09:52:43AM -0400, Alvaro Herrera wrote: > In sub GenerateFiles, I would move the stanza for ->{openssl} next to > the one for ->{gss} and keep the simpler lines all together (your patch > leaves ->{nls} as a separate item, which is aesthetically unpleasing). Right, thanks. This makes the flow cleaner. -- Michael --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0SyPAACgkQnvQgOdby QH1FwBAAi5u0DLjlXzqzJFlMwNQn5ffiTJkGJhVyT/V/EXIkpbCob4TZ2pyweV+c e2CtmogT/oOi49uh0QIeo5bjn/p+sGmzXZYL5JPhqV7ntIs9gY8WIt0A6Vak0oMa AEOvVWcoVCOJ5aPHF3cbWephqI8Nzf4uWFYfm6j62TgYCyvHBfW8qe7MdCdnTSUC wMYziuEcAFFAL1IRxrkgLYMberSNp2l+M5gY8Da6MZk2HVXbLSkRhxlJ8xZI29J/ ueu5sskGZZLlFBveGjlE8YBqXJS/nmaxIL7u0K8eycP05pOEJQIvbWnaDlbM/O4z 5a/7x1B3mHwjcXiPTUEQwEAq1GXH86VaVlnvfihw/9lRaZVIH1nUiK9SKQ5Zw7Ep OnVQ7d8LjFdsSIr6p/2RuT9j6d+JF89DlmXSIasIwNCiQwNogvrSIRYNLIGIS1bu u3jkMJREZeLPmse/FQMxwYmoV2bpqWLKRcQEVohrIpK5J0OEN0Vg5SemnZZcrAuz bS6HK03kMgmZ3WO8e032b+N5Yf5rHjg1liJmzbToJBdUMETetE518t8vx8uxsDmm DV89D34o/CudaI/Q5uMass2G7/lyRV1ng96NI393VK7gTsCcbbCjCPuid7x4i0Da sOFQz2wnMOS0cMx95PMlGMugC18zvJhHInV81CBBqE9EXvSrRUc= =ckZT -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV--