Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hixAH-0007Ak-JT for pgsql-bugs@arkaria.postgresql.org; Thu, 04 Jul 2019 08:32:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hixAG-0001z1-2s for pgsql-bugs@arkaria.postgresql.org; Thu, 04 Jul 2019 08:32:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hixAF-0001xq-RQ for pgsql-bugs@lists.postgresql.org; Thu, 04 Jul 2019 08:32:23 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hixAD-0002W9-Ld for pgsql-bugs@lists.postgresql.org; Thu, 04 Jul 2019 08:32:23 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5D8E02E6; Thu, 4 Jul 2019 04:32:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 04 Jul 2019 04:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=GD2LROpaCGTs5S6f9Z26mw7KYdn E9FEtIR3LIgFNbcU=; b=ceyIrywE8rziccOKKQeRzOg6bL1xsPNIs+9kjPlQJQR 7Uq5QmUUUSIV4oLFthaqAGmvGSqb5Hu5nG8e7vaCugHcvUWsCIkrvukbKHiDMZvh FfbHEnf0xtOjpiP2UmI9OiaFk6UqcFv7UwiK9TR9sks8Pm5hj2ikiuhy2ffHfVKW 57NjBODMUR6ErgmaV1mtbHI9hbIuiuqXf6UcLRFk0YSIC7xuNa+IOXPUmDNEtHH9 D79BYJvmm83rgIqSzsk1VlT0pV2yJN1TZoXHnZw8uhqGUyFaZG/Ke/SrLPxllex1 vqD5Ihfa3tbZFlVpNiBaE/CSCo2UrZkuqmN/DJHLNHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=GD2LRO paCGTs5S6f9Z26mw7KYdnE9FEtIR3LIgFNbcU=; b=RjCxaexnw1PNJRIQsT7I41 ERDVfOuPTZk5B4h+CQBhacjrkqz9O02wwfX4JKv574Dy6yyG9GwyBL0Qb44/qMKp 8CLwo/6OSS8tmsIaND8cLUn6e5XztrKYwVLjwcx9M6MqhNJAFW0pVX8YaTltCbuD P5OVCStmXkrSPrpDxkabIF8YymbJ4dZo3X9Bn57iCBgA7WswxceNdlMRsTPlb0Xa VNFQu9MCVkOitCxq12U1LgP/juQi5s5EGnI/0rigVteIJcwgXVdllQmLDe04kIkq 5h8/2m3+OHF3bLldmcEBk2Anb+XnTa1xDvcYki5c9FTYpOggUO0nvrrWpneSz5Ow == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddu necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 48F0780069; Thu, 4 Jul 2019 04:32:17 -0400 (EDT) Date: Thu, 4 Jul 2019 17:32:14 +0900 From: Michael Paquier To: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha Cc: gaolin01@beyondsoft.com, pgsql-bugs@lists.postgresql.org, Haribabu Kommi Subject: Re: BUG #15889: PostgreSQL failed to build due to error MSB8020 with MSVC on windows Message-ID: <20190704083214.GR3084@paquier.xyz> References: <15889-1ee90dbc3b860518@postgresql.org> <20190703113551.GH3084@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4Kq+wHeKEs1nwG7z" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --4Kq+wHeKEs1nwG7z Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2019 at 10:18:44AM +0200, Juan Jos=E9 Santamar=EDa Flecha w= rote: > In that building environment, if you edit > ".\src\tools\msvc\buildenv.pl" to add the following line: >=20 > $ENV{MSBFLAGS}=3D"/p:PlatformToolset=3Dv141"; >=20 > Does it work as workaround for you? >=20 > Anyhow, could you please share what nmake version are you using? As a side thought, we could also move away from nmake when it comes to find out the version of Visual Studio used if Microsoft is lazy with nmake's version number. For example we could consider using "MSBuild.exe -version" and parse its output. This reports 16.1.XX.YY for me with VS 2019, and 14.0.XX.YY with VS 2015. Not sure how portable that it though past those versions. Still, on HEAD and v12, we only support VS 2013 and newer versions, so we could integrate with it easily. -- Michael --4Kq+wHeKEs1nwG7z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0duY4ACgkQnvQgOdby QH3X+g/9Gq0Ckw/QsFboKFJDQtVQEwg1uVggb6l146IBZtp9N1a/kvo9dcBGGAEX iLN7Kf4VB7Z8APO6KOBaqhXI9N65TYEjIyqXTrvCnkfOa/6z7BWAnQELywPpGSEx FsyBcnZTN0I6hXCTVkGo2lqixMl8zRaMjsuKBwDhH6H4dl89rPwRxBkdQLRMWQVT RNfqAQjIRPVPgS5mcXEMYZk/yNx+TyMQtIDQ58MLjaWYr0YotHJL7MTi2F07azh9 CaqkUo1OZ8g4tJFxi79a3hQwLDiUbjv/Cn2fsca7AnUAA9wONmgk9PV4G62jgLcf gL9YcCC1NvmYHui0W+NLrWWZ8P1DURBaoWg1ViGKl5mfvtOvmgUkbzcI3imlXGL8 wf4zNxdoXkZoqauPEM+y/v7uXeokUT6JCNyLYhOzjZvIcO+r5QZyvx9WAqWMltmz XXkNpfK07cK9ZZkGhJvwN+9YYdEYIJgFVq5kcMFLj5iwV72q88QIIx+tym5yUc4X OFN6hTPJLRGLWGGW9M5HbCRnK4gu/AN5cQJjseWWe58lx1JJ5n3G6iSU2e2lV+fB 5QjgwuKDXnd5aCy8IuRVlbspaR25OrWWqJtiCm5KPvtyR5KGnfQQjgbhGPfFfnBD uCDIeLZAezw5kzolsLRmv+lIpuKRUpEZbAjgORqX6rfgnhPc1SA= =p0xH -----END PGP SIGNATURE----- --4Kq+wHeKEs1nwG7z--