Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hl4aI-0000ao-8P for pgsql-bugs@arkaria.postgresql.org; Wed, 10 Jul 2019 04:52:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hl4aG-0007Tu-9l for pgsql-bugs@arkaria.postgresql.org; Wed, 10 Jul 2019 04:52:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hl4aF-0007Qw-T4 for pgsql-bugs@lists.postgresql.org; Wed, 10 Jul 2019 04:52:00 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hl4aD-0006QY-JP for pgsql-bugs@lists.postgresql.org; Wed, 10 Jul 2019 04:51:58 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E1C8E21FD7; Wed, 10 Jul 2019 00:51:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 10 Jul 2019 00:51:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=aT0zkSfYIcVQtJh0b3mKNhh72I5 I8pInbBF20ZV05nI=; b=fvJlkbIQnkdvjpwadB21o0CpNmge7sYGId5t/K2C8P0 XhYiu6QCkia5FrvTQ6VhLEITnMv90CTby3SBI7gU46ZjKFs9BfriUdYOgDR7DNem kiBe6JfTcLjMmkXDdkFyWXMxMwiVbgH2yyvR3scTah0wZ1L2V8J21T4EKp192UcN BSVarIFfw8gQzRcO2jOedDMCTtcXFDUtnP3Qk5LawgHJfRADWB8C0mf4oAZV7VkI 083OU68ibUBm9rkYXTsk7yaaxK77k3VmL4fiEHOx/TJp5hhttpQjX1IvlXTv+SHK S2CUxwT0KL41Jw9mwwbJN6nX6AElZZ52cFg3GJYhZzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=aT0zkS fYIcVQtJh0b3mKNhh72I5I8pInbBF20ZV05nI=; b=TJmiaokd4JZbwjC8W+Hcqs uZT/t5uE/Ic8AKSSD8W5aXUyRy1kAJKUvOQJnRVkXh9D7ZcRKI7me8MJB1+FnlSk nHXpwQ1L/XuSK7sbe6Cd1YW0K7dXDYIRBHeEnJ/OUbz0jj2XseMsrZLM725Ev8yY TGqrO+uzavM2HkLyLqfTqejkgCECu1tEFkQEfZSyLJFHUHnJvAwfKROrtQnEVVUV kGP/GmUD9XGsgaI2nvER3PJe+N/2qh6433/tEjdtswu2gfY3Pu4CF57xqCZekG97 pO/uIo3zSX36/BvI6jMKjqeWPj5bl260IFFgjsgyk2AhPPVaSF8EqTED2Gkx0+9Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeehgdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuffhomhgrihhnpehpohhsthhgrhdrvghsnecukfhppeduuddu rddutddvrddukedtrddukeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvg hlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C4E58005C; Wed, 10 Jul 2019 00:51:51 -0400 (EDT) Date: Wed, 10 Jul 2019 13:51:47 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Andres Freund , marko@joh.to, pgsql-bugs@lists.postgresql.org, Magnus Hagander Subject: Re: BUG #15888: Bogus "idle in transaction" state for logical decoding client after creating a slot Message-ID: <20190710045147.GD1031@paquier.xyz> References: <20190709201557.y5yt57z2za2hu6l7@alap3.anarazel.de> <20190709214630.GA15632@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mJm6k4Vb/yFcL9ZU" Content-Disposition: inline In-Reply-To: <20190709214630.GA15632@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --mJm6k4Vb/yFcL9ZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 09, 2019 at 05:46:30PM -0400, Alvaro Herrera wrote: > Hmm ... so what that commit did is precisely to fix this bug. > Magnus thought at the time he was fixing a pg10 bug, > https://postgr.es/m/CABUevEwX4g8y=gmgfPzxFKS7gqjSYNR949Xc96OQm=YXJmh_Og@mail.gmail.com > but apparently now we see that the bug was older than that. Maybe it's > okay to backpatch further? Yes, I would not be against a back-patch in this case. There is a minor conflict because pre-9.6 WAL senders cannot run SQL queries but that looks simple enough to solve. > (Booh to missing "Discussion:" tags in commit messages) Booh++ -- Michael --mJm6k4Vb/yFcL9ZU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0lbuMACgkQnvQgOdby QH3QgBAAhoFsbjoE/K8dFpOBhxeZICVZ4GpsksXsGRgbPcdp84jO2drsKhaRtO74 Yk3YxPbZntoqrN3cIJrgYxRiJHvSd/CfvFExs2F2pv7GzLWm8QzbaCWbKeNDD2K0 okGtJbJ6H3zxsrWEGwgpeYjaFjx1gl6noTAaCuudFIMoI6+4VS1tFwRsR9H+LkXb uniTSuzS+W8Gqj9wywM/H3k4XVEEpmoKZ4OmOSdK7TIXOncEzcLqEknuKGmfW2kk Y1/LQcz3f7krtcqoOiLVoo/ujgbJ9Z/n35gZdpuFMDfnl8DyhP997jAp98ecsVxd gv2lhE0M3AIVhdjH2AdR0raGSHIzJZvxR6n5t1I84sez42y+PrwP+Etf/USx0ZsR C/xrgu5UTU9JV9AbTYEQfGnOW2Ua/W0rqS/NllpgrsyVX/0jfcCfVyvFoc9HaeAm 7lMwSt4MxJhPVurs36geHUgx9Mlynq/7ZcR/hrDqoeugBAwOTUcPZ7utb6w3LUh0 w90NDXAmRoUGLizCtrRH/hlG9hAQ6LDl4Mya59i/b97H4vOvJCby2fi7McCnEWd7 Ecs41rXQkHihG/Vx6QSqA6FhHECF0IsstUMVYtQryzWLQFImUC5FalAzHuAyUwwq uRiNRDE9opuWAG1txtwdUMpbHHeP4ragYcWN0+8xwkbiQqsX+jU= =yODp -----END PGP SIGNATURE----- --mJm6k4Vb/yFcL9ZU--