Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hl6cp-0005ZI-Cq for pgsql-bugs@arkaria.postgresql.org; Wed, 10 Jul 2019 07:02:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hl6co-0006kV-9Q for pgsql-bugs@arkaria.postgresql.org; Wed, 10 Jul 2019 07:02:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hl6cn-0006kN-Uj for pgsql-bugs@lists.postgresql.org; Wed, 10 Jul 2019 07:02:46 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hl6ci-0007js-UA for pgsql-bugs@lists.postgresql.org; Wed, 10 Jul 2019 07:02:44 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3008722116; Wed, 10 Jul 2019 03:02:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 10 Jul 2019 03:02:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=N8TLZ514DZZrVDCkv69mZOCIkiF E279LAYROezlPUb4=; b=nJLI/amp6MRsEt+fgInw7aDxWv0vfzLCecUMw7MROSM Pyj/LaRzyf5F5G/6xWHQSEQewSoItoyANrnrmQqUNF6vIjdtzECppnq3lkIw/6Df a4vT83hOt/PFNBMyLCbJ0peyF6cWxnBxVrO2S1Ahg4+I6nItRRA9npbetsU2ncuG gmHfHCtM2a1US//oUWJlL+VjhW7dnwqIk857m4XJPwAaaxy42a37VCIe0OIfynGi oCjM9vFd5ii/TG68XX/QgZoUIQ0Bt/T11mZatUN0y/UiOuqVFT8r1A/5aWZjqkSY Nb49y/m03bOHBD81se2O/EjVPFkg98PdQ5XN7zwFJnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=N8TLZ5 14DZZrVDCkv69mZOCIkiFE279LAYROezlPUb4=; b=UQhBxoxCZcgD/QiaaGcRZf U2vBECjapgwsT49Q+L62/Om+QM+RA3IVbhW6LOlHGSUzDNvNnBq1n2ItZNKZ9pdS 0p3KMZvxVHhuBP5lrNfQcoZsQOwg6qyA1HqF7jXEVvQAzCkEI1/0NxxFx5lZbcUM CDoKk2pkSz9h3XcT9mvX1kKL0zisluScdeVUd4wvUIAC3sVjFppAjTl1SPzPrPpn NXTa30JHEnbM6/eJUkIANhtr9z1xdgo4rxMyntQNZPJJPb8MLm0l1FtJC6lYZmeI JmOvnXCtloWxL6vCtyy+rtgQ6Njpul0rH52dg1hsTFYfFX7uQE5IV8hE4hgFcobQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeehgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvf fukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhi vghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecukfhppeduuddurddutd dvrddukedtrddukeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehp rghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 9EE7D380076; Wed, 10 Jul 2019 03:02:30 -0400 (EDT) Date: Wed, 10 Jul 2019 16:02:19 +0900 From: Michael Paquier To: Alexander Lakhin Cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15899: Valgrind detects errors on create gist index Message-ID: <20190710070219.GF1031@paquier.xyz> References: <15899-0d24fb273b3dd90c@postgresql.org> <38f18230-e766-3a87-e3ad-fef6562c0c23@gmail.com> <20190709044341.GA23827@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5UGlQXeG3ziZS81+" Content-Disposition: inline In-Reply-To: <20190709044341.GA23827@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --5UGlQXeG3ziZS81+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 09, 2019 at 01:43:41PM +0900, Michael Paquier wrote: > Regarding the zero-allocation, we have gistLoadNodeBuffer() loading=20 > directly the block's contents from a temporary file after allocating a > page, but gistPushItupToNodeBuffer() justifies that as a cheap > insurance. So that's good for me. Do others have objections or extra > thoughts? This comes from 1d27dcf, so this should go all the way down. Tested and committed down to 9.4. -- Michael --5UGlQXeG3ziZS81+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0ljXsACgkQnvQgOdby QH1Jig//csp3xFzgoNZBuyvB8PecF5IGtYnQMmetDrBDrIPS7BF6yih7SDTul6qD JW0ZKOUGI8zF/4uDkgaS2MFmCXdfz2FyD+Jnw1dEZZg712sayJTGAlaX1gV2Mh5e aLFPKRrFZ8PybZV0DoF050J3+z6M57Cvz2l5Q6xO3XmoeqeVqRvIyuiEzNh2cjOr fU3ene+T1IdmdvRQlo8CRIL/jQ9yGm2z0tQPScpm2DcE0+ToJDa3KeDls1wrO7xK V5y7apHMwUfh+Kj7BFI/o6faBIJbsaCMFbkDDAzgBmdl22Kpi/19kBMYrGMdsJSy MHx4jS2R8qZaLIY2WXgPl5puR6fFa2m5MIBCvgp2B/pf3cTOFSUHp4oaN6pGp4Qy loHAXYPCtR8p8sdPJ3w4CAd8bZvt8t2qJg5ltDOcr+6GnW+Yrx+HUPgkdmyMl9d2 4xr3/6Fdp54vyg+uHLZ3CAtEBUthDkDPZ0UFEPrm5WZU0q5OpGsa+lKtXav2XzDs gzbP4yhSdVhh0sln6keL8u7GpMzo6Q7PgPfAoWVH2ncYVkk7Cf9Vs6LKTGKEi0W3 2quQJ6dvrUGtnEH6RSF9AeMa+UDSV/42Lzc2nPvhf1aS+dopCVe76ZFqScV7ZV4k RRiDueNF+T5pTzy0c0zwKwL2lR+wG52nLFMVe9401DCGhThUUrU= =/IIR -----END PGP SIGNATURE----- --5UGlQXeG3ziZS81+--