Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1hoDTT-0005Jz-O0
	for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Jul 2019 20:58:00 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1hoDTS-0006Ba-IX
	for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Jul 2019 20:57:58 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hoDTS-000647-72
	for pgsql-bugs@lists.postgresql.org; Thu, 18 Jul 2019 20:57:58 +0000
Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hoDTP-0002Ec-53
	for pgsql-bugs@lists.postgresql.org; Thu, 18 Jul 2019 20:57:57 +0000
Received: by mail-qk1-x741.google.com with SMTP id r4so21560497qkm.13
        for <pgsql-bugs@lists.postgresql.org>;
 Thu, 18 Jul 2019 13:57:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=fUQpLS+Cz/wfv9aDAIDY4v0KUFsb+yuQvvx/cJVFUuY=;
        b=rDCpTfPdbWqPaG7h3b2w3kNDlMa74PJjDXB6QvT6MfGlw7qHV7xTCfITwXxoFp9dSS
         mRN4Y/jo03w7aSXJpz0CnavaHdiHVMN52Kg47rM6ZDw0mda4D+LIjZmbEQFNgQkiRM/z
         ehWbH7468EmKzj4ftuDW4ZtG2I2cKQCsZ1c5UqySDORtlTZGDukdeCjOchog+MM7z9MG
         pH7oCx6q08dL2Al+VWf7ha2uvzaxCVuLaa9wncFoSiIaiArKCqHTHkQCtrOJKYaryG4l
         W2J1fxj/Sm/vIvkeWQoWBQAZi59/EVazE9f0Qj/HxLxMlrNoPj8OgTMVakbQYdlV1+fk
         MqWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=fUQpLS+Cz/wfv9aDAIDY4v0KUFsb+yuQvvx/cJVFUuY=;
        b=TqGZn72Qd245T8NJVmfEfOJ4mYMCDBgLWPIB/OEGfzLfPwQYYInncSDiCkpLxbcAL1
         se4I3qN0NNJISut5buKZAWKz6CBqyubAZctbHeWuZj/nYRjbkkRME/3AreVKduxGn93v
         GE6N6BJ9qIOw/s0JfFZEyWv6l4yVNDzLTYJk3EXGgUX8D+Ollwf8q22KOxrcwIQFUgzM
         Wzv2Hs40q0Z/D8NV2hq/zHvhb0K9PcHYZvau9UY2X9uXgmnQI0aEdosocRw0AcB1uaXF
         3eFDEakJoPUbpkMsqJC+o56OtxRNy992POZM31CMstR9YGXOvdYLbsln18aSleD6zabO
         aR2Q==
X-Gm-Message-State: APjAAAVtfY0DHHrDeyFISYo1PW4ds0LoCRYz0/f6losD7NkuLN28mJzX
	38mAxEV8iVHyrLwu7kyCdyC/yw==
X-Google-Smtp-Source: 
 APXvYqwPJfUkgG+TH8FYbvoxWBUjDpPQfK+bYQhoOjlOH3d4ckUmBWg1IsoSxc/jJ2ZQbpAcehXcjQ==
X-Received: by 2002:ae9:dfc3:: with SMTP id
 t186mr30590385qkf.461.1563483472882;
        Thu, 18 Jul 2019 13:57:52 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([190.121.29.3])
        by smtp.gmail.com with ESMTPSA id
 g2sm11744804qkm.31.2019.07.18.13.57.52
        (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
        Thu, 18 Jul 2019 13:57:52 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 883701249C7; Thu, 18 Jul 2019 16:57:50 -0400 (-04)
Date: Thu, 18 Jul 2019 16:57:50 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Christoph Berg <myon@debian.org>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	Teodor Sigaev <teodor@sigaev.ru>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>
Subject: Re: BUG #15896: =?iso-8859-1?Q?pg=5Fupgrad?=
 =?iso-8859-1?Q?e_from_10-or-earlier=3A_TRAP=3A_FailedAssertion=28=BB!=28m?=
 =?iso-8859-1?B?ZXRhZC0+YnRtX3ZlcnNpb24gPj0gMymr?=
Message-ID: <20190718205750.GA23460@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAH2-Wz=ycyenry7PM1_i=1s7Od9hp7WHvZZHJ30oMDP0VFm8Ew@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

On 2019-Jul-18, Peter Geoghegan wrote:

> On Thu, Jul 18, 2019 at 2:30 AM Christoph Berg <myon@debian.org> wrote:
> > That version works as well on 12 HEAD. It passes "check world" and the
> > Debian testsuite on top of that running 10->12 upgrade tests.
> 
> Pushed a slightly refined version of the same patch back to the v11 branch.

Thank you!

I wonder what the consequences are in a system that doesn't have
assertions enabled.  Do we just end up with an "upgraded" cached
metapage, and no further ill effects?  That seems pretty benign ...
I hope we don't end up with an expected v4 metapage or something crazy
like that?  (I suppose we would have noticed.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services