Date: Fri, 26 Jul 2019 13:58:08 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jorge Gustavo Rocha <jgr@geomaster.pt>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15827: Unable to connect on Windows using pg_services.conf
 using Python psycopg2
Message-ID: <20190726045808.GF7677@paquier.xyz>
References: <23215.1560977098@sss.pgh.pa.us>
 <20190620031218.GC2660@paquier.xyz>
 <20190620070319.GH2660@paquier.xyz>
 <0a9fcd30-5ae2-7e5f-ac1d-60d14a2ebb63@geomaster.pt>
 <20190621004233.GA1626@paquier.xyz>
 <3383.1561078113@sss.pgh.pa.us>
 <25605.1561652435@sss.pgh.pa.us>
 <20190628031056.GA1797@paquier.xyz>
 <5805.1561750411@sss.pgh.pa.us>
 <29487.1564071212@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Bg2esWel0ueIH/G/"
Content-Disposition: inline
In-Reply-To: <29487.1564071212@sss.pgh.pa.us>
Precedence: bulk


--Bg2esWel0ueIH/G/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 25, 2019 at 12:13:32PM -0400, Tom Lane wrote:
> Hearing nothing further on this, I went ahead with the patch as I had it
> on HEAD, and a tweaked version of your patch on the back branches.

Thanks Tom for taking care of that stuff.  Coming late at the party, I
have one comment post-commit.  Perhaps we could have a wrapper in
charge of doing this work in with something adding properly \0 at the
end of those strings for CR and LF and returning the new length after
adjustment, like pg_strip_clrf in common/string.c?  There are nine
places changed on HEAD.
--
Michael

--Bg2esWel0ueIH/G/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl06iGAACgkQnvQgOdby
QH3Iww//RJgoXNbwBAUNdV1yPNGm2dolB1b5dvKIk96nL9OnvqbSsS5LTtH/AQ5K
s+lmT9nLRgQ4HouUPYS8rbqwxe94hf35Vi54s7bpFCWAfhJj9K+ZBsbF6XLyeAV6
xKe/ZutzTlWY9OtFNMvxxBXrEfuu/RRGJ9oKnpYA7ca64YGGfyZKzKdfY8ZIfrw4
1+egh4eVFxEMJ5ndqSXqG8YaOoSf+l8/J1E8et7Murt6lCI6BASI2k5W5cXf7lUf
koaGF62EpcgG3U29EIBbXTm6BQdYIbaX9SrkkV10PaXz8rd5JPhn24coxtSwYFyL
g/a/GNNG07R0wClnAEqIEl+yDQ7Jm574mfBgfiJfkIU3/YCARXSEzAqPu1ZG2tUF
H9c2z36w44Au16GiI4km5YUY8b4+Yh8/PEJrqPWQ6dX5ktr9aXiDFZTs3UDQKBqj
Eod4V446SbZl71TQdC6ZuHu8WzyEX/0Oy5rxslUjjUOzGCMKCI9HnQwkISssz0Ca
PYRdG6XYsiKqJjik38qUDL6b8aCSecg6vdU2231LrNTRx/2efUPKLFs6giF2tsUA
CTHBDtSPsFGt8h6um+OaC3XxdK8uH4mgIVlJkq5vz7wkapMFxwl/5oyF289SZzFW
cUCgNNAFuYzE17V7AVMo8vRYCxLktVP8vvm/U1VGteWOivt7C3U=
=Z9Fl
-----END PGP SIGNATURE-----

--Bg2esWel0ueIH/G/--