Date: Sun, 28 Jul 2019 19:45:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: jeremy@musicsmith.net, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15883: Event Trigger Firing Matrix Table is incomplete
Message-ID: <20190728104555.GA23790@paquier.xyz>
References: <15883-afff0ea3cc2dbbb6@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP"
Content-Disposition: inline
In-Reply-To: <15883-afff0ea3cc2dbbb6@postgresql.org>
Precedence: bulk


--5mCyUwZo2JvN/JJP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jeremy,

On Tue, Jul 02, 2019 at 02:57:50PM +0000, PG Bug reporting form wrote:
> The event trigger firing matrix table in the documentation:
> https://www.postgresql.org/docs/11/event-trigger-matrix.html#EVENT-TRIGGE=
R-BY-COMMAND-TAG
> claims to list all commands for which event triggers are supported.

Sorry for the late reply.

> They are:
>  - REFRESH MATERIALIZED VIEW
>  - ALTER DEFAULT PRIVILEGES
>  - ALTER LARGE OBJECT=20

There are more missing entries:
CREATE MATERIALIZED VIEW (missing for ages)
DROP MATERIALIZED VIEW (missing for ages)
ALTER MATERIALIZED VIEW (missing for ages)
CREATE ACCESS METHOD (down to 9.6)
DROP ACCESS METHOD (down to 9.6)
CREATE PROCEDURE (down to 11)
DROP PROCEDURE (down to 11)
CREATE PUBLICATION (down to 10)
ALTER PUBLICATION (down to 10)
DROP PUBLICATION (down to 10)
CREATE SUBSCRIPTION (down to 10)
ALTER SUBSCRIPTION (down to 10)
DROP SUBSCRIPTION (down to 10)
ALTER STATISTICS (down to 10)

>  - DROP OWNED
>  - IMPORT FOREIGN SCHEMA

These two ones are correctly listed in the table.

If you use this set of event triggers it is easy enough to check all
of them:
CREATE OR REPLACE FUNCTION log_any_command()
  RETURNS event_trigger
  LANGUAGE plpgsql
  AS $$
BEGIN
  RAISE NOTICE 'command % for event %', tg_tag, tg_event;
END;
$$;
CREATE EVENT TRIGGER ddl_start ON ddl_command_start
   EXECUTE FUNCTION log_any_command();
CREATE EVENT TRIGGER ddl_end ON ddl_command_end
   EXECUTE FUNCTION log_any_command();
CREATE EVENT TRIGGER ddl_drop ON sql_drop
   EXECUTE FUNCTION log_any_command();
CREATE EVENT TRIGGER ddl_rewrite ON table_rewrite
   EXECUTE FUNCTION log_any_command();

I'll go fix all the ones I have noticed, down to where they apply,
thanks!
--
Michael

--5mCyUwZo2JvN/JJP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl09fOIACgkQnvQgOdby
QH1Ojg/9Fs7ZiLQWXxkPUovbB5lYj/yyv3gvA2lDq8LZKVwq7F7T/8EmvAPy/dV5
qqpeHVW8H3BTnhXnhoantMi09yHwOX9vm5sqH3obOEmtoaO/r2PgQk+ZPHLJ8KoF
Z2Li90SURz4ivuc6DTWrZM5WRfisn2ezKCrW9CR+0NkMeJldzrjgzlGg+VwUqnbt
zJ7RwamTagbDPubomc82UKLqNjMlB4eBFW8CsYtXtlewXSDaAzc/SCWvDPiDYtWH
fN/SDxK1m19fBiSs8WV1DLP5uz7dP1d7psf5G0AIRXPPe5pnAjz7eedDS0N/puHW
zRf1jeGyhZZsILORC537mu9nvyz2tes5o23etM6E3LDlYWRiz+XzLfQH5XjFR9Cf
mcuS5dc4PX2xAhxDzQfFB69iRHijKEyOAPCP+9VW0FwN2eFB6HmupAVyKodd3NJK
ev6LuGENB6Mk0Nd6uJp+Zw/yWdSrlSmNjbfC+1hFW+m5Pq9mIlR8rVblPnXinr7G
1/w3V7IxUvxC50b3/mzW2N2jaFBA/1JhbpitzQUnjYwsKLREpA7qjoF7ED6bHzQQ
6Erkf4R2nsbofQ06lt2vAkJRuP/kPlsERQ59PjTbouzVzIFfTXq2tnRNr+TXeqPv
XaK7acspUt6FFqxjGd3BUOti3FnTf7YCHiDkN3lFKLUMmTpAG0I=
=W578
-----END PGP SIGNATURE-----

--5mCyUwZo2JvN/JJP--