Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hsipM-0003GI-Qs for pgsql-bugs@arkaria.postgresql.org; Wed, 31 Jul 2019 07:15:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hsipL-0004qz-Ly for pgsql-bugs@arkaria.postgresql.org; Wed, 31 Jul 2019 07:15:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hsipL-0004qs-93 for pgsql-bugs@lists.postgresql.org; Wed, 31 Jul 2019 07:15:11 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1hsipI-0006wQ-P2 for pgsql-bugs@lists.postgresql.org; Wed, 31 Jul 2019 07:15:10 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B1FAB222CE; Wed, 31 Jul 2019 03:15:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 31 Jul 2019 03:15:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=nx53AEufHIkBIyV+qf4PbzPoXB0 MkoBsN19cnOhyQko=; b=sDGfUI/r5haTOJyvDoOmVCHthe651RgRGXJOxklTDoV l9jhdQdww2ma0F+eEin715SKeNiDfi+u2ztwA8d5rycPHZKvgvj0Wzc0t/mS5/yl +mZEmmF0DBsGxD/MStH5qYsdIbOOi7Rh7vq1TLw7x+9KCC/Nqj3r6ASbiq5Wnync ml8k05RurnER0v67tvCJ/pfXLiBhXqATIyCKi4iR2QhfIWq+iQhPwztjPqC1dyu5 +VfAirBYzMwC31F7mDByuCCPmz1nKDAPT/iZVRxwDGElhGODnjwBsqF33Hf/owPv N55qihDcENyx190EgNwVILnlJ7ZJoYryFtj2dxGlQRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=nx53AE ufHIkBIyV+qf4PbzPoXB0MkoBsN19cnOhyQko=; b=EtFDsy2ynnru8pncW9Sk2T ugNIUgzVc9JDWVr2lDYEsHD+MBCKlYfiNsizKa741LA0PUd4KV9jikEzXZmObCd5 pJnTe5pFBLI6f+ZQLYQGcWxtpXe9MAFasU5zyj+8qyFDWBLGjLewAvmYyndFoI7z 0X8KOOTvqAJLnng1ab7mapqOUSjQ3hOr7hXEAaYp0rw+3nKrugfGI/XaWwe5XuhL nyFfxMyJLHclpt/JWIg/AZEN5ARmwetl5Mi01eEXMwoXZSv3jAUkfZy1hkUt/0qS fIfE8LK078DnUpQHGROE74ymsf+Y0ijG021AhSWlQycsW9AIrKShpOmAuKQ2IWOg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleeggdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhu ihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucfkphepudduuddrud dtvddrudektddrudekheenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhes phgrqhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D91E80059; Wed, 31 Jul 2019 03:15:06 -0400 (EDT) Date: Wed, 31 Jul 2019 16:15:03 +0900 From: Michael Paquier To: rafaelthca@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15932: Module passwordcheck doesn't reference previous hooks Message-ID: <20190731071503.GA29334@paquier.xyz> References: <15932-78f48f9ef166778c@postgresql.org> <20190730022420.GC1742@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk" Content-Disposition: inline In-Reply-To: <20190730022420.GC1742@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 30, 2019 at 11:24:20AM +0900, Michael Paquier wrote: > So, it would erase the trace of previous hooks if loaded last. > passwordcheck holds value as an example of use for some hooks, and > examples should be a good students, so I agree to do better and fix > that. The attached patch does the work, what do you think about it? Are there any objections about that stuff? I would not touch anything else than HEAD for that issue. -- Michael --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1BP/cACgkQnvQgOdby QH0gTQ/+MB9ZxhmLBKnf1RKPCAU5dKZYJdPxWdg54TxhbegGv4qj5tKER0jwX/7d J5IG5EgpfDau/+cokeczpTQd/g0NbF+8VOQJdTnBFYexGjHYp9UQVAZUwfZG6Vqo MzeVE7lcRpjgqRqssrkkjlnipEHB8mcfe6o3ASMbr3p3ss0CmV/+mTIVMiVY8AIG tLoQvEaanH1f7rBfzdlsp9nlKmgWvy7P3gW412RV/QCbyRq7Fil+PrO1xOA56MLC CHlSu40tpDJ/7M2E10OmGQ6aTy6wxtK1MrCztrxfkmzGGPZ3BpM2TqeO30T0FL3i 6dH4Q+9dghbVe2N2n9IuOlxEKbrLckM+QcOzMEFhfU4VmT5xUkeqyZ+dvpd9hx0i 0kpkPvdtBSjGK9V+HZw3xDsbzxjc16PEVYcj1HkMuQ+CnqRNMENwFdlUfGH8n85m G8tOtD+WFjkaMssZAKbO3WfICU4dCYmvLNGVhIbN9USfe6O+8sF+gZ2h/H5IR6wz UHEInwSCy/Oa0yir4JsdCo6hfEe1lQ/Pg5bnosxwK/AZgAgJd12ATmiuQ2CJwb7O ZS3tWOted27TH8Vmy/RPc0h5j2VVWGqokuKFkKMyavJdbRR4S9Jhiby283XHTYCV L/G/mLveKYUHOccHteWi7FVFuJLqGVyP3i8WUXlJcJlbvY5dzeY= =DJbq -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--