Date: Thu, 1 Aug 2019 09:42:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: rafaelthca@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15932: Module passwordcheck doesn't reference previous hooks
Message-ID: <20190801004211.GD29334@paquier.xyz>
References: <15932-78f48f9ef166778c@postgresql.org>
 <20190730022420.GC1742@paquier.xyz>
 <20190731071503.GA29334@paquier.xyz>
 <97C01A5D-D814-413E-A8C8-146B17FBB63B@yesql.se>
 <20190731073401.GB29334@paquier.xyz>
 <B8D6D6DC-484B-4D14-9CAD-F08B486E0B8B@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3Gf/FFewwPeBMqCJ"
Content-Disposition: inline
In-Reply-To: <B8D6D6DC-484B-4D14-9CAD-F08B486E0B8B@yesql.se>
Precedence: bulk


--3Gf/FFewwPeBMqCJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 31, 2019 at 09:54:17AM +0200, Daniel Gustafsson wrote:
> Hmm, ok, IMO my comment applies to those as well, but it may very well be me
> just reading it wrong.  Either way, +1 for pushing your patch.

I am not saying that this cannot be improved either, still I am not
sure how it could be reworded.  And if we do that, it should be
applied to all places where we use it.  I have fixed the issue and
back-patched down to 9.4.  Perhaps that was not worth caring about,
but the versions for the back-branches were not really an issue.

Thanks for the report, Rafael.  And thanks for the review, Daniel.
--
Michael

--3Gf/FFewwPeBMqCJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1CNWMACgkQnvQgOdby
QH0QYA/8D6E/p3W8BgkfsXF5IyeRa0TfL20DVYWf+WOABHZIj2Na7ztbqaj87Yqp
MznxtU3j8+cOD/F85TPKWOOalsmlE0BMLZTTIgqmIzMbTgezh7uPjRR6L7abKvdp
5C7KRuxaOFYh+T8Gh+FkV9KLLesmUr3c30DjzYQoiTshB5+5Nvhvlx3SDgOOMuuP
Cw+FNU9zHdCg57iY6QUcbVeZIezaVFsrz7lNpX8Vcqi2TI9JawCrx2h+dvPThTbh
B5onsHYW1m6154xQLG18v2J2PIhfpDrymQwdlLSXXxYCTSYNhI2/FfNcpC8zW1RL
MAbmb3JLM7stNyDi53kQSVLCeOjaMEclkYc22g/i18aD27VW5MsTElig1PN98CcB
nXDedNlEtrX42QwIddS5RN21VL6C4N7Hm7hXgfhhvUONgEcbp66SyO9VrDVX3YoV
5LzK/6juTny8dG5mMsEAmU1XJoJZDxX1JPn4bxQWJXM52e+RHYFijk+JLT7v6XHr
376/g/bHmjIoxn72YUA2cC4kz4GQCZhu08qruaXcssILKMjAxH0OMGMXWwgqJPl7
q1m9BENrH3HVat+D7KqVipHWtDMeQvFeF1Gh8FAGea4HtN2BHNXHOdrGentcHNks
HUachq9kYo4NC6B7PsRntasJuEDBFRoIUcK9hSu2+IXmpqoqE4g=
=KxhG
-----END PGP SIGNATURE-----

--3Gf/FFewwPeBMqCJ--