Date: Tue, 6 Aug 2019 15:21:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
Message-ID: <20190806062111.GG32256@paquier.xyz>
References: <15910-2eba5106b9aa0c61@postgresql.org>
 <0aaf1cb9-0f85-e786-fb32-b3d68b80d027@gmail.com>
 <97ac4fe2-65d9-6a7b-76e0-5ad3b06cd9dc@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="X+8siUETKMkW99st"
Content-Disposition: inline
In-Reply-To: <97ac4fe2-65d9-6a7b-76e0-5ad3b06cd9dc@gmail.com>
Precedence: bulk


--X+8siUETKMkW99st
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 05, 2019 at 08:55:55AM +0300, Alexander Lakhin wrote:
> In case this bug is worth fixing, please look at the improved patch with
> the corresponding regression test.

In this case, DecodeSpecial() decodes the abbrevation passed down as
UNITS, which is right on its own.  Still, afterwards the code fails to
correctly set a date from the string present.  In short, your
suggestion of fix looks good to me and that's more consistent with the
full timezone spec case.  The test case you added in this patch
triggers the error in the code path where the timezone is not
specified.  Could you add an extra test case for the timezone
abbreviation?

Note that the next set of minor versions is very close by (we are in a
cease-fire period for commits on back-branches), so this won't be
fixed in the upcoming releases.
--
Michael

--X+8siUETKMkW99st
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1JHFcACgkQnvQgOdby
QH18yxAAmrE+doZ1EdaOV3bp3HhoquLUnX0MRQjIGJ+aO6OiFdXGXbNgBQRs5aSv
s6zp4ZU2XdUnGMnBvHEatWKaiR+NqThGg12jy6W7mSQLNckI5aGMOk0nLVACSMX4
o5bcVxEJfGRVWTV+TFzRR6AGyt8aTv5C0hvd2L2nKn4zZ7STpDej/73/WBJZ1WlM
8PPKRDVM3FUB17tW/N/1ZXW29AXW1KndTqygD4aRl6Kn750INfx94PTFO7W2WICi
KIpO/7V6XLomcaKLQN76cmrcPvShRDHih6XNsrGuv1TbO2iotPTMnZ6fMR9iVxKB
CeozEHHAeHRsAnsyv9sSnOiczBJbdDms3EfHXHFy4DO62/lhiSBnsMQImRevR5Pv
8pIUXdbuBgnBGHzUrelVf8NPtjpFj7VRrA6GY5NvLJKURZRlxIXCE9m/hcydoKwV
ixRSp7Tw+OPPj65SftBsxHP69N5yk0qzjucbT2rXRp4NHgzbtPsB3R/muDFyw21E
B0eDZGb81D12XQxZCU1omTW64tzSmvcOSxoV0EGhyzuDuQ2XMkm86pnYUf9oDt7L
hiJ1F9o9fuNX2grmVvM1SH+9F9YeJFyexCeR7tIOkRbfEIkmZ8rUI4/TOSS7rUzH
lbLMputKZVuSLeLklAUICBhbD3BMYqJOkOd3vppNN3AKE3h/BiE=
=fz0Y
-----END PGP SIGNATURE-----

--X+8siUETKMkW99st--