Date: Fri, 9 Aug 2019 11:35:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Merlin Moncure <mmoncure@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Dmitry Dolgov <9erthalion6@gmail.com>,
	yarexeray@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15940: json_populate_recordset fails with ERROR: record
 type has not been registered
Message-ID: <20190809023505.GE3194@paquier.xyz>
References: <15940-2ab76dc58ffb85b6@postgresql.org>
 <20190806073209.GI32256@paquier.xyz>
 <CA+q6zcVYyjDEh9hkKi3eG81TBghMRjVySNA4gAsQU0q4gJPbFQ@mail.gmail.com>
 <5154.1565120306@sss.pgh.pa.us>
 <CAHyXU0yu3otAqneN=B+6oRXgDqEAqJt5EtYBn55vGX_PzBpj=w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5oH/S/bF6lOfqCQb"
Content-Disposition: inline
In-Reply-To: 
 <CAHyXU0yu3otAqneN=B+6oRXgDqEAqJt5EtYBn55vGX_PzBpj=w@mail.gmail.com>
Precedence: bulk


--5oH/S/bF6lOfqCQb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 06, 2019 at 02:53:45PM -0500, Merlin Moncure wrote:
> For posterity I agree that OP was essentially exploiting undefined, or
> at least poorly defined, behavior.  For my money, I'd advise using
> this function for cases where you don't want to use an in place type,
> just a column list:

If I were to change something here, that would be this error string
exposed to the user.  With the current error, there is no real way
that the user knows what is wrong and why he/she should not do that.
Could it be possible to add some recommendation for example on top of
an error "cannot do that because blah"?
--
Michael

--5oH/S/bF6lOfqCQb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1M29kACgkQnvQgOdby
QH3Bnw/+OcQKjgwurwA9JWkmwfAzI1ELWwZ3CEtvueAesx6ceR1n/Oh9axpfOEHd
CHt+8vVx9ycKozZ9c6gfa/GdC1Fn8DZ91SF2IAjKGeCWKAUHVWLuiWs8BIgp7TFY
xt74AY91yk99LaCFZN1Dr/mLdeoq6jpZWXhW4+Wz7J8akDDeTOPxwMjVfEbYJ0rC
j7ClEH+UUKnELDPN7Px8gKk/wwUgWbPQAe9j5vFuk0P+CSDjI5WRIGnwRER0UpSA
WTzW5W+BybVav0kCqv5V1Kok9DxW1VBMeX9vCyX7Dcbsssu0xmbd+QpZSb8j95IU
jOG+pfy8g4ZSZiVnrIraxbDVmKjFNdf95mqBAG7CNVpiAfg6xon1e/KsZjEUmU1t
tCi/7l95yPuXJX4oxKRJz7TYRWGFHFNQyMoh9vwxzpLiSxri6Nt8OGNMLPmwDy0W
Q45uK+/+0g3RvSWUj1zdkhI23RPCbmALX4sPOL0cmxy945nRcZddQt1IPNCiGp7Z
3m7kDjySBaF3tHrncBzbKJrM+01z4p8B6qkpm4yX8fZ5xsIV3e8nCJXUhwiey9dV
ZgC95cUtm+dbS6U3MI/fLO9+X84pLKPyxyeU8OkGhQarQQr9Dl8bn4rtfoyNirwx
uh+gRRgKCkKjfE0dmnZqjNb4O8+APbB6bA0hhlAw8e3ipMC7Xrw=
=iuYx
-----END PGP SIGNATURE-----

--5oH/S/bF6lOfqCQb--