Date: Tue, 20 Aug 2019 22:40:05 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared
 identifier 'FD_SETSIZE'
Message-ID: <20190821024005.GA16883@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190821015854.GD1684@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Aug-21, Michael Paquier wrote:

> +			if (PQsocket(conn) >= FD_SETSIZE)
> +			{
> +				fprintf(stderr, "too many jobs for this platform's select()\n");
> +				exit(1);
> +			}

BTW why fprintf?  Since you can get into this by careless use of -j,
ISTM that this should be a translatable string.  I'd consider
pg_log_fatal().  Maybe something like "Argument of -j too large for this
platform -- try %d", numslots - i.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services