Date: Wed, 21 Aug 2019 16:36:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared
 identifier 'FD_SETSIZE'
Message-ID: <20190821073619.GC26424@paquier.xyz>
References: <20190821015854.GD1684@paquier.xyz>
 <20190821024005.GA16883@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KN5l+BnMqAQyZLvT"
Content-Disposition: inline
In-Reply-To: <20190821024005.GA16883@alvherre.pgsql>
Precedence: bulk


--KN5l+BnMqAQyZLvT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 20, 2019 at 10:40:05PM -0400, Alvaro Herrera wrote:
> On 2019-Aug-21, Michael Paquier wrote:
>=20
> > +			if (PQsocket(conn) >=3D FD_SETSIZE)
> > +			{
> > +				fprintf(stderr, "too many jobs for this platform's select()\n");
> > +				exit(1);
> > +			}
>=20
> BTW why fprintf?  Since you can get into this by careless use of -j,
> ISTM that this should be a translatable string.  I'd consider
> pg_log_fatal().  Maybe something like "Argument of -j too large for this
> platform -- try %d", numslots - i.

If giving a recommendation, shouldn't that be linked only to "i"
instead?  If for example numslots =3D 1024, but that we get an error
after allocating 128 slots because of a lack of fds in the range, then
we would recommend 896, which would still result in an error.  I quite
like the suggestion from Andres to keep the message simple with "too
many jobs for this platform's select()".  You are indeed right about
the pg_log_fatal() part here, I have changed the patch to do that on
my local branch.
--
Michael

--KN5l+BnMqAQyZLvT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1c9HMACgkQnvQgOdby
QH34ig/9EuoNEy3pLP/gQg1pMKvKQA7UWyWgM3DcaNXowP6Dpn85Kk0pMggvXvhW
o3f2Ayb8hD8HJ1M049mQArkb176vrzFR2OJHmnfE09cv9Hw5TqPNp5+YnJ2weZxS
UR9YI3rH0g8I2mOZaS6etJ5DCxg4m+8hC/gkGopZjAVGHAPKQWKaxLgAZ7l2RZs9
cWUqipu2nkJuoyZuv7aM6cW/Uzg0reYSksblJwdj2AYkJlOaQCaJPJ8a/Bb+KoGL
9BXvxFD46hosatAq01F6NEzS3N6wc31vdFoiE1JlOnCvzOV8J0xZQXEcCyJ/983U
Lp8kqvCIy+PW0VTfuLsdCLpLu4Dh1MnBnoZIEDbphAmSQIdaPIrwcri3t0QeWJMo
0olFciv9Biy21IbDNqI/ijHDR7Nky91ZgyflOjGJhzCNRprpcFD1okOorSKdSkZX
j2Q7COytizMHvM8I0lymsWRCkC0hM1rx4qCnWPFXUzTfTBXr5Cc8faeOjbS6Fv8S
iRiS3ywdBOkDHEx2t9TUOSIKHNqvlUH2xzaYuP7qCNxDluxH21nQ4G5/uIk0Op8S
z+94FpzVhbitbHZrBcoYX1kIXP4SJu7GLCcCC/CFJxcQ8pBEylAHjdZuPW8urQzK
Jfsdtqljr/FN8JUf2rihTLOpzTp3iCPKWki1xmi2h0UzU5bgJJk=
=fG0t
-----END PGP SIGNATURE-----

--KN5l+BnMqAQyZLvT--