Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0RDT-0007er-2Z for pgsql-bugs@arkaria.postgresql.org; Wed, 21 Aug 2019 14:03:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i0RDR-0007PM-Oq for pgsql-bugs@arkaria.postgresql.org; Wed, 21 Aug 2019 14:03:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0RDR-0007PF-H9 for pgsql-bugs@lists.postgresql.org; Wed, 21 Aug 2019 14:03:57 +0000 Received: from [66.111.4.29] (helo=out5-smtp.messagingengine.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0RDO-0002rZ-Q1 for pgsql-bugs@lists.postgresql.org; Wed, 21 Aug 2019 14:03:57 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 43D3E21FE0; Wed, 21 Aug 2019 10:03:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 21 Aug 2019 10:03:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=BFfCa6/jTKZjIhOq2NsraL73zSK C9cx3gxpLZCV5wMw=; b=YLWyaH4QgssDB8i0KJsapJu6vufCIAMGxH3qlPH/sap WO4w8aMf7TaUzwPdrpLtGtGZZAmRGPTiCgeoJVoJYEduzwPyzGPLrpqNXZZ7i0qo z8ySGT2IlGhrT3GCY9WrPtl1gMo3YKZ02bETp7mg6G1mHFuWNeNvGraxzB8Wtlpc PlSd1ODmGALi8Ku9OlvNYhY/3Hhtk6jsF6GyafF2CiVvxG5Jdmas+uSo66UJqGGq 9C7JqUHXt2NN/7lwz24MajxXUHN5XxJqkQ5Ct63Aa6D/eKOgdu8GtmJup4T9tUpf RavvsdEl/JSXKgc6ASqnHTg/EdlBrAPu+6xOzCdpVQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=BFfCa6 /jTKZjIhOq2NsraL73zSKC9cx3gxpLZCV5wMw=; b=ziINRmLe6TbxgVG2HFY2jn xraHe3DgmxP9bL4IoN4BLJ4YuzeDNnHijQn+djzwjkKafC9AntoFO5MsKNi7krPf d5h8ziG84gApxLzR5juLSpXoDAvAyzzJvLqqy8qjUrKXZuQODO+wSdlzwmjCgSQt nKhIqwQBPe27oJ9dWcObYDUYpVpEhjC2Tvvi/3J6NMht7Xlsi6yTZCyX75ktxrLW k3OWISoVz4NqjjzP8kn7kVMCAU7auOndMcR0R0VMeWW1hCdqvg2UJQew9JlGGR5Z AqG9xTIgBpwjfOBlzT+/qxdbdeXuL/lINu5PAnJnvad95vamhyVuYMrsLMg669RQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudegfedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepudduuddruddtvddrudektddrudekheenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 0938BD6005E; Wed, 21 Aug 2019 10:03:00 -0400 (EDT) Date: Wed, 21 Aug 2019 23:02:46 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Andres Freund , Tom Lane , Dilip Kumar , jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' Message-ID: <20190821140246.GE26424@paquier.xyz> References: <20190821073619.GC26424@paquier.xyz> <20190821134954.GA26174@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Yb+qhiCg54lqZFXW" Content-Disposition: inline In-Reply-To: <20190821134954.GA26174@alvherre.pgsql> X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.29 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Yb+qhiCg54lqZFXW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 21, 2019 at 09:49:54AM -0400, Alvaro Herrera wrote: > On 2019-Aug-21, Michael Paquier wrote: >> I quite like the suggestion from Andres to keep the message simple >> with "too many jobs for this platform's select()". You are indeed >> right about the pg_log_fatal() part here, I have changed the patch to >> do that on my local branch. >=20 > Well, it's a user-facing error, so I'd rather make it user-friendly. > It doesn't seem difficult, or unreliable enough not to try. Still, in this case, because of the nature of FD_SETSIZE the hint may finish by being wrong, no? I am not sure that it is worth going this way. -- Michael --Yb+qhiCg54lqZFXW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1dTwYACgkQnvQgOdby QH2aCQ/+ODQJs15Nh/h8l9ty5YteVOCerpDP3LXPYgnOLgSLRtf76uHIWQgKAwcD G11xACi0JTO1PX1IWZWwy5443D5Km3dIyzgU4NhxAWwWGI/D1J1vAGHrDPlIZimQ LfzPg0AX/Ay7q/4SxkJYjjUW3xkiR/9tG6ShIVFLQF+DM4jD9oTEORFe63Rd9ids LnJwGc5SQ9sVcAqz3FJNglH0LwDEHBgIOAZCDV6sDwg5YZUydn4a7ecnjgZV8yaA 4PeLEGCR2Z03amxh7PTT0g9Y3/vv8X3GHDfo6pBorj86wh87H2Cpea+URvrgJtBZ fg643s+GcISHInFOLg/pEygvZSnC+JDljf7+BQFqoAWbPiz6oHfsAI9vI0O7PS2t C8bsSWh2rgKVCkpTS0chZxUNlL2eOy962IjdOai08O/2IqEcHtg9KWgRourQQqpl VKompnKgw1fB/ee1HIoFGvsZ6489LxUo3nUlTg23tcCp+w1fAgBeH8hdQvuKBM2B teKBCIPPAjqslUKovl17ElFDO1GDwVK3vX0wCnw7coGrpk6vTtYTjvRaMuJQEaae Z0r9QEk5tR/dCklhd1JWTEa9azGiUpeuDkUVneT4zvuFt0xKY3kR1JXPwdOQ/2NU zi66OHZp3bRpYa50LbUT9qmKknrLmH9nAgPXIRVIGQh0CGDSPFY= =76tL -----END PGP SIGNATURE----- --Yb+qhiCg54lqZFXW--