Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i1LiR-0006cB-2W for pgsql-bugs@arkaria.postgresql.org; Sat, 24 Aug 2019 02:23:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i1LiP-0006SC-T2 for pgsql-bugs@arkaria.postgresql.org; Sat, 24 Aug 2019 02:23:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i1LiN-0006S5-PM for pgsql-bugs@lists.postgresql.org; Sat, 24 Aug 2019 02:23:41 +0000 Received: from [66.111.4.29] (helo=out5-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1i1LiK-00062o-6L for pgsql-bugs@lists.postgresql.org; Sat, 24 Aug 2019 02:23:38 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1DD6521111; Fri, 23 Aug 2019 22:23:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 23 Aug 2019 22:23:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=B1Ju81/R6e/UrG1ERa3YpZzuM4s V7ba+MN7WoxvsvAA=; b=cfOgLlIUf3x2blAtVJ+grcnkq5+kLLstKfy/JsnCkvK nIfJX+izexj/28D0mOIt/ipufidRB3Yr+jpg8/8Y3mFdp5FolHqzHroOZJdLDnFT 8ElDTpuFJTO1foxie+nis7Q6J7rZNl1YMtTxV57z8d1AaWX9rTXAjDiAFqWfAyMv RLgN19gE3wl9ESy4Did4pNfT6AsQSis3h4aTO6kxKO4kFqvZ1WkZjyeqkiZTb1L5 XmhqaAL/vzZ39gcT18fSMhB5faFfCp/dRX6Gc/PYYJSQ+mFdWT9gQXRCSWg3Ydxk WmgQ6tbQ2o7+Wk+bQ4X7PBDtTa647d004tyaxdypu7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=B1Ju81 /R6e/UrG1ERa3YpZzuM4sV7ba+MN7WoxvsvAA=; b=l0rDbQwsx3CZ9lzCCPLOVm AkLUXCa7cc578DqW5XL0+OFlfUaUhsdIQnyJ0+QJgWRWheAY1TWlLtOYy7d7HtHF FczWbGwNfXemCNU8Cr4I/WlkUN57OALiwOzTU87wtQdOhuQOqV2NI4sMpQ8gsiN8 58RBvi57pJWDQOp31OeIFSlg20u0siBX7R/UFEqs6SZM2Rb8C0fJWVuqfGyAblwC pTssgUfBTaI/2EHvJjcQh3b4oCAzooD6MIsdeFoMhVUIq+/tuEo/L3nwjv5WZXKZ nAWLgfOU+50pq2qDBgfP0JQCkgxahLJqLqIkQO1pi5jrgsZ/sqJ+qKcz82BJyI9Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudegledgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepuddukedrvdeguddrvdehuddrvdegtdenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (mp76f1fbf0.ap.nuro.jp [118.241.251.240]) by mail.messagingengine.com (Postfix) with ESMTPA id 61B49D60057; Fri, 23 Aug 2019 22:23:22 -0400 (EDT) Date: Sat, 24 Aug 2019 11:23:19 +0900 From: Michael Paquier To: Tom Lane Cc: Andres Freund , Alvaro Herrera , Dilip Kumar , jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' Message-ID: <20190824022319.GA32189@paquier.xyz> References: <30820.1566397711@sss.pgh.pa.us> <20190821143449.GA27852@alvherre.pgsql> <20190822014739.GB1683@paquier.xyz> <20190822150945.3xgbvk7qqyqkyjse@alap3.anarazel.de> <20190823015921.GD2328@paquier.xyz> <29797.1566572294@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline In-Reply-To: <29797.1566572294@sss.pgh.pa.us> X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.29 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 23, 2019 at 10:58:14AM -0400, Tom Lane wrote: > That seems over-punctuated, plus it burdens the reader with unnecessary > detail. Most SQL folk would be confused by the reference to SELECT, > I bet. (In fact, don't we have a style guideline against mentioning > particular syscalls?) >=20 > How about just "too many jobs for this platform -- try %d" ? WFM. Do others have any more suggestions? -- Michael --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1gn5cACgkQnvQgOdby QH0ztQ//YSfMTB1JGl29TftOU8/XvYbCTKlPjkZYOdVoRWbTMlj0cXsWL4MtoJBt lq35Jki/PzGX+ZsU/Y5/RvBSWvW50iV69zKtNkNWQzQ5OpIOUrIVBnjJnqZaP6WE xzXCSvOFNHx096exH4nLdPrctT4XuEh/key7+mkTRlabe8G8HiJy6vqi9AhrTIIH iJZFEgjZFxdh27T6vQva38VjqXWMerm6KlONz3gYu3WnfS23yhroaTICvJNxtGfu KjX6XoFa2pX1/aBCeGahZMuqU9PV8jacbyuBat45MmAzCfXwR5cEUxwawv9AziSq awQy7E+jQiZ8Ws4au62CvNBpMFDd6764HuzzEaOIQg/SrHhMf01h+qZgJIqVxV9/ CknHf+DxMUYUs3HlbcL0xl61TQZ0OULLqxJYEpwIJcCgmrYPwGjmpstaiFAy0/fN r2TZFgecq6Mu74n+pI9HK/PuQapI2fIA5dgjMpULHouuIOEeiqA9+Bptd1rG5Sqh eW6ZXKEnYa/tPfGzFkIkwYzlDseKYdmv5wXUpq+fGi5lI7bdCgJJHTvXyGaye3z2 huOdoWpz2H6k1kACOvr64Svr9md9v5ljmQvW0Xe6bbt3LXoMUKAom/DipbAbfG7L r6jIshxnYidMHRf70l+SItLfT+Bq5fEkcB7BRP27Aj0sPSlMVw0= =sFEs -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM--