Date: Tue, 10 Sep 2019 14:39:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
	Andres Freund <andres@anarazel.de>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with
 EXEC_BACKEND
Message-ID: <20190910053923.GC11737@paquier.xyz>
References: <22995.1558278322@sss.pgh.pa.us>
 <27719.1558282181@sss.pgh.pa.us>
 <16df9d01-8b03-2664-a18c-16c40186f5ab@2ndQuadrant.com>
 <2702.1558289980@sss.pgh.pa.us>
 <20190520012728.GC1923@paquier.xyz>
 <1664.1558325417@sss.pgh.pa.us>
 <7927.1558364465@sss.pgh.pa.us>
 <31457.1568057723@sss.pgh.pa.us>
 <20190910051115.GB22934@paquier.xyz>
 <6728.1568093331@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="adJ1OR3c6QgCpb/j"
Content-Disposition: inline
In-Reply-To: <6728.1568093331@sss.pgh.pa.us>
Precedence: bulk


--adJ1OR3c6QgCpb/j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 10, 2019 at 01:28:51AM -0400, Tom Lane wrote:
> But the external PID file is a different story.  I can believe that
> something might be expecting the sockets to be open before we create
> that file --- and since we're not using that file for an interlock,
> there's no reason to be in a hurry to create it.  I think it'd make
> sense to move that step further down, so it's still done after the
> create-sockets step.

That's the actual take here.  We cannot assume that nobody is relying
on that.  If they do, it could be tricky to rework this logic.  Moving
the external file write a bit later does not sound like a bad thing in
itself to keep more consistency with the past.
--
Michael

--adJ1OR3c6QgCpb/j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl13NwsACgkQnvQgOdby
QH16ig/9FgIJeEpA+CwH4PTl2gBJ/T7Ema0o5OSFJTvn71upmpOhxwvlwK4JWy/U
U4aj9/PShv4WVykbo+AgdOjXTTsTcF4lbPUkLDFPcst6qbTJmKYT67hoWMY+3aFN
8Y3Js+1KPpoK0p/i/J9Iw/QnIOc8hBveuekFC4A2Zb7/YL3+sbiaCTzMspfpFerD
HT/JoTZlwH68zEaDrC0ONAtTpooCXohlAn4wsbtJJLrjXFHotBCoZvXntN8SCSm3
2OjttzFIybIrloZ1q5BuPxZdLaz68l2AnzYPkZoi9lILvfgVY0R2dl1CtJ+owpvf
7FSMEvHxncBXSomiRxACrBLSbUU0RCbSmJ/TKQ4ymd/xWEVUGZt7WNeQ1QwIc89c
FwIRfnEYoAYEfWKdGpvSCPgJo1SEd0267jMHwaS+spUa2ETwsN8fRAssejT3GAvu
PURpFhJfhRIfnYSNjyEi7Z/h5YoEUHyu9zod7UN0QJn8+ubseehuKeCnuo4a24zY
NCFxDO2Kj0lQNazGxydkxXu2UbTQiMWViOViH4tMMnJABSeYVj41rHTWGegMfz7P
Ndqs5ciNyQ3peR57QsmpD3BtPdTv2U/roZSpaYMerXLGYrno12q9rj2doSZ7vbSi
T6+vm34kisOH/N0/U4cJdyiGX25tG6oqovH6YwtW8X8tmqNKoEg=
=KzCq
-----END PGP SIGNATURE-----

--adJ1OR3c6QgCpb/j--