Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7sBs-0005js-C3 for pgsql-bugs@arkaria.postgresql.org; Wed, 11 Sep 2019 02:17:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i7sBr-0006BM-7T for pgsql-bugs@arkaria.postgresql.org; Wed, 11 Sep 2019 02:17:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7sBq-0005MF-S9 for pgsql-bugs@lists.postgresql.org; Wed, 11 Sep 2019 02:17:02 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7sBe-0003Gd-Re for pgsql-bugs@lists.postgresql.org; Wed, 11 Sep 2019 02:16:57 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 692187B3; Tue, 10 Sep 2019 22:16:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 10 Sep 2019 22:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=S7YW844rJLxexR8e4ByLySxVMGx EeBvxhvMr9dODXMQ=; b=F4T92wOTUxG1s/VsiCz4CuXaue6PHQCFg3wbd0JRZy0 P+t+lNJglfkVspQJC6LzqT6rFzccNSQDNIyEVQZzU7IhlUoLFLG9rMmeb+Y9SdDF bXGJ+HlFbuNZFBmrle5t3YTU9KEG2XeO6qN1UGmJ0r7oa9un7phCRCNIr53RyWoz G/fYfb+r+J5cXrPOu1ae60X+AmSh3s4hu5LWfKdVYNakq949+KcXGLW1uGLSUl1O uVI7NMNCXRZK+SCeNVF7T9axd1vLMI2AicXv9KFPfmNlh4+24gxg6I5I0uaBuRv7 lkVAlXSTwCcg/7/3QHsaLP1e5L2yu9uUhkTK2pPIj/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=S7YW84 4rJLxexR8e4ByLySxVMGxEeBvxhvMr9dODXMQ=; b=MoI2sqekTddnt/vm3iWTEm UW6EXEs0U/cZp5BL3Yae1WHfZr/5AUD6d3tITXzW5MQidHD5ggnAI1uBL9zGUtis kCo5m8bfritBrGjZmXZqDuq5M9gRm9ca5ebozxnCQVG4fkaJS4yjgYt83ng/Ox6H hDh/OY0TGCDuhisdfTWdqJICNBgLEXjxbNuFIKjdMKX9gtW55w7ANYT2BI2amYRf 0d4Tf8qJalYK3BkJPnD3eZscvUdAwvVcjjkSuJDrZyG2WvcBTAkHi0o8N8scvqdB EshuUDSO4I+4RmoPWMh5FBXxS4cvb3No0BeE52Jn80I27eum911LYFj+hXctGXgQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtddugdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 268E58005A; Tue, 10 Sep 2019 22:16:43 -0400 (EDT) Date: Wed, 11 Sep 2019 11:16:41 +0900 From: Michael Paquier To: Tom Lane Cc: Andrew Dunstan , Andres Freund , Peter Eisentraut , Yuli Khodorkovskiy , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND Message-ID: <20190911021641.GC1953@paquier.xyz> References: <16df9d01-8b03-2664-a18c-16c40186f5ab@2ndQuadrant.com> <2702.1558289980@sss.pgh.pa.us> <20190520012728.GC1923@paquier.xyz> <1664.1558325417@sss.pgh.pa.us> <7927.1558364465@sss.pgh.pa.us> <31457.1568057723@sss.pgh.pa.us> <20190910051115.GB22934@paquier.xyz> <6728.1568093331@sss.pgh.pa.us> <20190910053923.GC11737@paquier.xyz> <20705.1568127532@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FsscpQKzF/jJk6ya" Content-Disposition: inline In-Reply-To: <20705.1568127532@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --FsscpQKzF/jJk6ya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 10, 2019 at 10:58:52AM -0400, Tom Lane wrote: > Here's a version that does it like that. After studying things a bit, > it seemed like a good idea to also move RemovePgTempFiles() down, > so that that possibly-slow step still occurs after making the external > PID file. Everything else that we've moved to before that step > should be reasonably quick. Good point. Nothing more to add with this version. Thanks for caring. -- Michael --FsscpQKzF/jJk6ya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl14WQgACgkQnvQgOdby QH1pnw/8DEjICPLh3Wldedb/q/eTmCYS43zdStMDlET7M0te/2shSm8ZnrtOFt0O 9AYWV1kIhTsFR3/XcF1uDjD1KP7M+8MnEu3PGez46PjaY/hpWYoc7wR+oVnUBz4D NmwGceeXbihlYQXKUMSg5laOVv6lgqHFiktqaH22rbq6Z7utde65wm+LUpOIegui SWZbJYnh+8TE833NQW1qAFr0HIyiiNBG2frSH3/MYoOgFADnnpBZpFhKc4rNH92N FQP8ozazUPrE/lLL09rUVuNAlXDvWn/NzpoyCH5knZ2KvuxG2bjdtxcWsKT9F6Bo tGA8w5AyNzuitRXcYcsH3QPEk5tJUpRNrsNowmfHCdiygRC5qScB6tTwG98JN4wy 9uE3eO8TcZ0BtE0K/Qn5aQAQCxD1LhIznU7SPA0F9d3TYXBCyVv1QMUim3tvwIOu URJ1caCBk/kCyWD7J1Fz9V+O3IgXdQYbbT4bBaiVIJTTfUUKsLiAGijSZuVrVmf4 OkUHsmfCqjU2IAgBjFTQtXtbcvlp5a3tPBmBEsPd5udPF8x9BhmE9MJmQJdWlI6v eSYO2nfvbMuNH8J/MfaGOjKZ0j47WiRtYFqwE7i859yaP1cpsY0SaXaXJzC2eP/n 8oddAcvMdTtP8jEiqfqV2CliUtJIY8ApHhrpT569mAuJ+D3eCVU= =YTnC -----END PGP SIGNATURE----- --FsscpQKzF/jJk6ya--