Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iGOoK-0002cE-AH for pgsql-bugs@arkaria.postgresql.org; Fri, 04 Oct 2019 14:44:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iGOoJ-0006BI-2H for pgsql-bugs@arkaria.postgresql.org; Fri, 04 Oct 2019 14:43:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iGOoI-0006Ay-NO for pgsql-bugs@lists.postgresql.org; Fri, 04 Oct 2019 14:43:58 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iGOoG-00036F-8c for pgsql-bugs@lists.postgresql.org; Fri, 04 Oct 2019 14:43:57 +0000 Received: by mail-qk1-x743.google.com with SMTP id w2so6027027qkf.2 for ; Fri, 04 Oct 2019 07:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=WGxOAMQF8MSdmcgfJc9pF8+jP2SBKnpg1oP8hCe1gyI=; b=Y+VFKEN+0GJYrh6qJcUYJQFbIC0kzD2pKD9+mPsR2aMTqqpIKJ63fGY9RQJoZfS8ar mrt+sVKYAE36sx9by34J3bm8BKhJ9s9mk3FyGzourTgOzRMZ07rWeqcfntRGNqVFeV4q f6Wxp7crj7kSZV0pFglzAgMAOs1gsnNTvjSGVvTzKo78qXHNSN8/9eS3wZ64OPVcoqR4 RbeeqEnX+9f9qrRBxtPxF7XYH9L53JNkImLlcRksy8+796b6PwA1BaXqKTMQPI+Ahe1H n7o/fcvaYIVb1XC1n/IRdOikIwvEjXR2PBo6R6bV6ugrs+Tk0vjNOq9s9wAKTtqFzfsP 9v3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=WGxOAMQF8MSdmcgfJc9pF8+jP2SBKnpg1oP8hCe1gyI=; b=ZOMDI8Q4chEFaR5Zqahc7rcLwdg2rc6VSU188Iywe7/1IKuxtHVFTGmW/aPoGfLwTd COvHLMgWQiFnCh6xVWI4/+8aH9jj1xb63rYFxvdhZSpJ3EnP/HcGEmRVVnUIkOlny51p nGhQiZ6yrHzWyANN0YQQFER5kAQ7w2ZEuuZj8m0sabc844yJa/+X36Sk6WrxaOKLhmej o5DdfyS4hybUpRJpnBBpAiYSaxfKgRnhSmzUcadkDCMYxFhhgP0jXgA4HPvedRQhSoRD O79bG6YyYkqougoNcTMZ2GPcHbzudeeIdFPhSsVPW+qhbEkpXDaqtxEgd9S4X6CHJI/K bTNQ== X-Gm-Message-State: APjAAAUwPUcPRRr451uSzRQmq+DD1DGz0HyaJtfxRwbppc++iJLSZ96i KHWjQwkE7H74lEot4JnIfKDY3A== X-Google-Smtp-Source: APXvYqwKLfnY8orTYow4MFyhecG1j52veRfAAl4CVnfiRsYfdZeZC37aV4TiAvEtEzseiCYC0ufcrg== X-Received: by 2002:ae9:edcb:: with SMTP id c194mr10083772qkg.121.1570200235141; Fri, 04 Oct 2019 07:43:55 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([179.56.30.174]) by smtp.gmail.com with ESMTPSA id z46sm3801963qth.62.2019.10.04.07.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 07:43:54 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 8A89E300932; Fri, 4 Oct 2019 11:43:52 -0300 (-03) Date: Fri, 4 Oct 2019 11:43:52 -0300 From: Alvaro Herrera To: deathlock13@gmail.com, pgsql-bugs@lists.postgresql.org, Andres Freund Subject: Re: BUG #16038: Alter table - SegFault Message-ID: <20191004144352.GA15934@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <16038-5c974541f2bf6749@postgresql.org> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Oct-04, PG Bug reporting form wrote: > alter table test.testa > add column idb numeric(10,0) NOT NULL DEFAULT nextval('test.sq_testb'), > add column fk_tmpb varchar(20); > > server process (PID 21884) was terminated by signal 11: Segmentation fault > - empty table - alter goes ok , split alter into 2 add col - works too Hmm, confirmed, here's the stack trace: #0 0x0000561459590e9f in heap_compute_data_size (tupleDesc=tupleDesc@entry=0x7faa37b16618, values=values@entry=0x56145b26ba30, isnull=isnull@entry=0x56145b26ba80) at /pgsql/source/REL_12_STABLE/src/backend/access/common/heaptuple.c:138 #1 0x000056145959232b in heap_form_tuple (tupleDescriptor=0x7faa37b16618, values=0x56145b26ba30, isnull=0x56145b26ba80) at /pgsql/source/REL_12_STABLE/src/backend/access/common/heaptuple.c:1061 #2 0x000056145975f881 in tts_buffer_heap_materialize (slot=0x56145b26b9c0) at /pgsql/source/REL_12_STABLE/src/backend/executor/execTuples.c:713 #3 0x0000561459761083 in ExecFetchSlotHeapTuple (slot=0x56145b26b9c0, materialize=, shouldFree=0x7ffffc491bbf) at /pgsql/source/REL_12_STABLE/src/backend/executor/execTuples.c:1618 #4 0x00005614595e09c4 in heapam_tuple_insert (relation=0x7faa37b159e0, slot=0x56145b26b9c0, cid=8, options=2, bistate=0x56145b26bd68) at /pgsql/source/REL_12_STABLE/src/backend/access/heap/heapam_handler.c:250 #5 0x0000561459715614 in table_tuple_insert (bistate=0x56145b26bd68, options=2, cid=8, slot=0x56145b26b9c0, rel=0x7faa37b159e0) at /pgsql/source/REL_12_STABLE/src/include/access/tableam.h:1126 #6 ATRewriteTable (tab=tab@entry=0x56145b25b5d8, OIDNewHeap=OIDNewHeap@entry=16396, lockmode=lockmode@entry=8) at /pgsql/source/REL_12_STABLE/src/backend/commands/tablecmds.c:5039 #7 0x000056145972a9b8 in ATRewriteTables (lockmode=8, wqueue=0x7ffffc491d08, parsetree=0x56145b24d7c0) at /pgsql/source/REL_12_STABLE/src/backend/commands/tablecmds.c:4641 #8 ATController (parsetree=parsetree@entry=0x56145b24d7c0, rel=, cmds=, recurse=, lockmode=lockmode@entry=8) at /pgsql/source/REL_12_STABLE/src/backend/commands/tablecmds.c:3848 -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services