Date: Sat, 5 Oct 2019 09:34:02 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: stuchalin.d@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16042: incorrect .gitignore file
Message-ID: <20191005163402.cotdvskqglhar3wn@alap3.anarazel.de>
References: <16042-c174ee692ac21cbd@postgresql.org>
 <8877.1570292881@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8877.1570292881@sss.pgh.pa.us>
Precedence: bulk

Hi,

On 2019-10-05 12:28:01 -0400, Tom Lane wrote:
> PG Bug reporting form <noreply@postgresql.org> writes:
> > The source codes contain the file src/bin/pg_waldump/.gitignore
> > This file contains the line /*desc.c
> > This line does not give the correct commit file rmgrdesc.c from this
> > directory to the "my" git repository.
> 
> Yeah, somebody was being overly lazy there.  I cleaned it up.

Seems like adding a !rmgrdesc.c pattern would have a been easier?

       •   An optional prefix "!" which negates the pattern; any matching file excluded by a previous pattern will become
           included again. It is not possible to re-include a file if a parent directory of that file is excluded. Git
           doesn’t list excluded directories for performance reasons, so any patterns on contained files have no effect, no
           matter where they are defined. Put a backslash ("\") in front of the first "!" for patterns that begin with a
           literal "!", for example, "\!important!.txt".

Greetings,

Andres Freund