Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iHdQv-0006ro-K9 for pgsql-bugs@arkaria.postgresql.org; Tue, 08 Oct 2019 00:32:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iHdQs-0004si-NB for pgsql-bugs@arkaria.postgresql.org; Tue, 08 Oct 2019 00:32:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iHdQr-0004sM-7n for pgsql-bugs@lists.postgresql.org; Tue, 08 Oct 2019 00:32:54 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iHdQn-0004TS-3z for pgsql-bugs@lists.postgresql.org; Tue, 08 Oct 2019 00:32:52 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id F200621C7D; Mon, 7 Oct 2019 20:32:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 07 Oct 2019 20:32:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=hhvNdshVXK+9ntgaLsLtTdZfJ5K Q+v1Ec6zQ+iO7bhM=; b=HbmybffK04Cd3uScL9e7hQEMsR+2SKL1y7uj7cTrAcz RrB3IvFEVD64RZ05bMB7aKtJoiso5zC7a63LLUe1eQrd6dhGuJOLSIPc4ootpMp/ WPFz4cO7IPovabUPNw5JtJNFNbRiB8RzG51AcoCbVdc5AUMjwaB4eELxhJcek6Yf iIyctPqhvO16UdZvPM633CsogrSPeljfaE1JSSqMlnT3vYHWsjZw+dZbsyEA/PDL +EHjxhtIUeB/CrLNRqbXAQACWUoEgrX+HKzX2kkELvUNt/d0uAl++KibZRt5wpu8 i1ssEMMZ/1AO2mb8Y4pBjWLXbnjCYidSOYM6uoqDnsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hhvNds hVXK+9ntgaLsLtTdZfJ5KQ+v1Ec6zQ+iO7bhM=; b=fe7KfMvkSYUTGfDpwU5Wz9 Znbx/0PbSvvrx2eKWQoIQgzf1lgjKShrvg/cPhfQnizI96NUF2wgDZgi7qmVVGT5 ePoU2iBkOG80OYnKF0owF3WC2HSTxcA6PXpxoPe1yoOFFUeiApyvqd3o7HjRKrx5 kCtcXbmouJjnduvUcRsiuVCzM26PWkQOWsD3SmmY44VG0P+9Se3XAHm74JXAtGhm utPpjqqYXKRKhrokoRuPg4usxAZQKGQwNOblcSO+Sd5JIVEjf710RPrATBbUUoNL ksRORsuvSu0Pg9l6TkpkNLWvaa5ZrC3ylv3HxVJrEXmBJAeVAQ61KHKoGsGoKwzw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrheekgdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B94B80059; Mon, 7 Oct 2019 20:32:43 -0400 (EDT) Date: Tue, 8 Oct 2019 09:32:40 +0900 From: Michael Paquier To: Andres Freund Cc: buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org, Michael Paquier Subject: Re: BUG #16039: PANIC when activating replication slots in Postgres 12.0 64bit under Windows Message-ID: <20191008003240.GA1613@paquier.xyz> References: <16039-196fc97cc05e141c@postgresql.org> <20191004200605.yqcmn75otebwcvyj@alap3.anarazel.de> <20191006045548.GA14532@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: <20191006045548.GA14532@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Oct 06, 2019 at 01:55:48PM +0900, Michael Paquier wrote: > It would have been nice to add some sanity checks based on fcntl() but > directory handling in pg_fsync() makes that annoying. Anyway, I have > checked the code with a little trick, and I have spotted a second bug: > CheckPointLogicalRewriteHeap() fsyncs a logical rewrite mapping file > with RDONLY. This is incorrect since b89e151. Andres, others, any thoughts about this issue? Are there any objections if I just fix it? -- Michael --OgqxwSJOaUobr8KG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2b2SgACgkQnvQgOdby QH3FPA/8DAcOcy6J1CI2jB4KR6M0wGuoI78c79ejpQU1wtY+m410IufxEsmNDvdC h5WtyQg9LyOvoW5T+OYllr98HA4zPvufmZxZPON1VgoKOGoos9tN2GXaGyn0YCU4 x4SixappiKLQIWB7RJI8DuvCuI8a9ffTEAtzVkPvMn+sVgLICa9vCA5Yei8/NjOW 641xhUJ0mgTAOTRzj7f/n1wzXJPoUbRyKQ9wkeLb5gqMetO6fAFO+tQfz8ulE4wN EC9CjDXK/E8MU+fWJMlVgGHuIfy1wEpkv75tcT6DUq7GFnyPMaAqC02c235dgHzF B2Ph+EmrBoCz+p5wHec2rYEeUPTZs66SO+7D12XLXCbVpIxmqljC5zXaXBj5rE0e wsVvb1j6ieW+9XYUuf3IYZCuOXGOnYjekjF31QGI6y5x2eNzT53WAsU2H60UsgAa tRRd5OfhYBvpLerr1Pz4hKa1ec/l8npDyOF9FJmXF4U0FRwI41vYEatt2j/++A8w L7lR+2ZYmQZTd3OhJc5otd/uKvFDfznZiQdLfk4NvQb8nEpMKYJQ7qMY0+L9YI0C apQjoOs9LgYlVMOfr1ckUyLd0WvIjak3PCR4nD3Oh0BNTO5JQ7g6DpzmrNw9OEZ3 oTZaChi6uPnBYc6YSWjjQWnhfQalrbrLvXqxS9bFRdmRZHLUGCY= =6Kmn -----END PGP SIGNATURE----- --OgqxwSJOaUobr8KG--