Date: Wed, 9 Oct 2019 13:42:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org,
	Michael Paquier <michael.paquier@gmail.com>
Subject: Re: BUG #16039: PANIC when activating replication slots in Postgres
 12.0 64bit under Windows
Message-ID: <20191009044207.GA21379@paquier.xyz>
References: <16039-196fc97cc05e141c@postgresql.org>
 <20191004200605.yqcmn75otebwcvyj@alap3.anarazel.de>
 <20191006045548.GA14532@paquier.xyz>
 <20191008003240.GA1613@paquier.xyz>
 <20191008160953.odwxuxiy5agci4fj@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD"
Content-Disposition: inline
In-Reply-To: <20191008160953.odwxuxiy5agci4fj@alap3.anarazel.de>
Precedence: bulk


--HlL+5n6rz5pIUxbD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 08, 2019 at 09:09:53AM -0700, Andres Freund wrote:
> I wondered about adding something like that too. Not sure what you mean
> by directory handling problems? Couldn't that just be solved by doing an
> fstat()?

Yeah, we should just do that.

> Yuck :(. Luckily that's a pretty narrow case to hit.  We really need
> windows coverage for this stuff. And also just general buildfarm
> coverage, it's not like we're immune from bugs on unixoid OSs etiher.

test_decoding hits that easily for me, and we test that on Windows for
some time now as there is a buildfarm module.  That's a bit depressing.

>> Andres, others, any thoughts about this issue?  Are there any
>> objections if I just fix it?
>=20
> Not here.

Done this one.
--
Michael

--HlL+5n6rz5pIUxbD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2dZR8ACgkQnvQgOdby
QH0n5xAAg9bRFOm3602tZHfxeW2iYIuZfN5YEjyxiZWJ/elOnKBokm3n6TXS3wnU
c5+feucwxAQqU32Ed6cl17iQ7o48kiI7W0f1SF0dS9fRZcdz3YZzcfGYaqHxAyGn
SpExFSYlgLD8XvfneKbHzG2pQrAzloae7vnW6prsYqKsy3WnKNETjm/4CkWeex9S
EA/UYSzq5B4knKNz9VXQbejgTtm5KRw7TFcp/2KgnyxuserrdybJQOL1XB6res71
pNntJJta8maxcFGMT/I2kEPOw7Dbe6udMPrCqBghrtCDAboysh9Vlnqc7YOYnEak
opNikhpybCnIWDJSSVpowrEvJ1bS3oqJcF14b4Pn3D/WB6BHFVUG6zBppt+36s50
T7NrErVSOSO/ZPtBPtWPiWtVDmfPBiqQ8OGQFBZ6fVy09mMKXMC4bANUVyAzsZkU
16HJQgOrx1dB7ry5be9ijwnbn6qDyr4pnSLK5zALS62GDcoSPN3fXss3b5+Z3qGy
h1aaDt3JB7JyXQ4COieXc5qOc5cVDYBcu/VAXRyxRwzbR7aGdQibO6BWMqoj6sE7
kpPvrL9M0NyK4fkdh1VQ0qnrT27tH6eAy+6fW8SOoLt/VWYt1qFat753GPrwVkXV
rD/4RtaMb9Wyuxq/TcTObIhz+wKGuWMuHoXQ0TG/eGp6Gmznxl0=
=SWeT
-----END PGP SIGNATURE-----

--HlL+5n6rz5pIUxbD--