Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1iINa4-0007KF-Eb
	for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Oct 2019 01:49:29 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1iINZ2-0005H9-NG
	for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Oct 2019 01:48:24 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <andres@anarazel.de>)
	id 1iINZ0-0005Gm-PZ
	for pgsql-bugs@lists.postgresql.org; Thu, 10 Oct 2019 01:48:24 +0000
Received: from wout4-smtp.messagingengine.com ([64.147.123.20])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1iINYw-0002kq-Cr
	for pgsql-bugs@lists.postgresql.org; Thu, 10 Oct 2019 01:48:21 +0000
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
	by mailout.west.internal (Postfix) with ESMTP id 1348D592;
	Wed,  9 Oct 2019 21:48:16 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
  by compute5.internal (MEProxy); Wed, 09 Oct 2019 21:48:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm2; bh=Htx+ZlgZpdKXIaVhTd7oJnnAs/Q
	Flpplp6i94pt+grY=; b=OzUzpuDYCHnz1XkEsG+Fd2YcS5Nv6CcDzsE7jn2sI+1
	oHJ3rzXXumq77+R4EO94NT4urVVSztDB1hokVuab7iaes9H9A2iF1rIHmIu8WlG1
	Bu5/JAkcsjkU7ynDFiPUSGTLvB5qr+rvO5m/4FtNATC3T7JVQkyJqFdC8nGGQUa8
	NLfrYuG2pMu5Y0NHXPD+Dhe7V+mTj/UqnNusPAwkJNjBr3xeTGgUAoU6Kmo/3b/D
	Y6CHERMgNviI04Iy0mXVl1MoLNrT4bQAHOwJPeSO4jYcR9g+i51jts6iXx39rDF6
	5SM0qOFHFulluCTbbPPkb0d8pAh/XcgdXBkxDlwKC+A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Htx+Zl
	gZpdKXIaVhTd7oJnnAs/QFlpplp6i94pt+grY=; b=yGhvePnGsd52VK5BamdcyI
	78RiapPSANzTWfFrF8w8KOGNke0rwW8tITuw1/xJATGyc/Rhm+FHWHe/Prczu6Oo
	hmwvm0WITKarEjvh0QjLJ71zQ0r8n+rWaWKsNSYbPofbIjCcM5WCHAE+ytncXM76
	+ERgOtjPL+/cjFgqzs532PiB7ihMHUjPy2FBw5YWgI032Tv/+kdDWZ32CqkDMjDv
	xf7wKmZuvlYbbarzmyL5YokLHbCBWttSPYfJccpOglI/WiVwhE3tN3oLiB5f7dwA
	sha2AyBJrdrsD2LceONTUab/HmavXY9lRcRUvPSeUp3Tj/+g8PChoYbb7bS7Fq8Q
	==
X-ME-Sender: <xms:342eXbiuq8Ldnzn5Bt1YixYuV31qvLLBDP2Nt_xLb_p5jdDC_9CgkA>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedufedriedvgdehudcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughrvghs
    ucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecukfhppeeije
    drudeitddrvddukedrvdefjeenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghs
    segrnhgrrhgriigvlhdruggvnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:342eXcSp12RMDkUbFBMdKJe4SYLYr8W1J_0rcqtjm3i8XGsmLcg0Rg>
    <xmx:342eXWFNtOwZAJFCnzpLYjHkFv9VIMj504mjJE99iMFYsyXlUVVKcw>
    <xmx:342eXckhtUj1KpVP_RZNr_vwTxXi3XjMisPZqdyflnFSJVmShlnMYw>
    <xmx:342eXTxq-nSpMP7sYGS0SqwNpqocpDTph25voRvLD5FFsFtit5hWsA>
Received: from intern.anarazel.de (c-67-160-218-237.hsd1.ca.comcast.net
 [67.160.218.237])
	by mail.messagingengine.com (Postfix) with ESMTPA id D6AEC80061;
	Wed,  9 Oct 2019 21:48:14 -0400 (EDT)
Date: Wed, 9 Oct 2019 18:48:13 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, buschmann@nidsa.net,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after
 pg_upgrade from PG11 to PG12
Message-ID: <20191010014813.3b2btmkakhrskwgd@alap3.anarazel.de>
References: <16045-673e8fa6b5ace196@postgresql.org>
 <20191009132436.uugh4r3be6vw6ex4@development>
 <20191009135907.km2b5nrzflcz6xey@development>
 <20191009141841.my6k44wfiaquj3ks@development>
 <20191009230759.ge66neof5qj627a2@development>
 <19314.1570663125@sss.pgh.pa.us>
 <20191009232836.jg77wccqwy5fgs6s@development>
 <20265.1570664514@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20265.1570664514@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

On 2019-10-09 19:41:54 -0400, Tom Lane wrote:
> Also, even if we did try to silently convert such columns that way,
> I bet we'd get other bug reports about "why'd my columns suddenly
> change type?".  So I'd rather force the user to be involved.

+1