Date: Thu, 10 Oct 2019 08:25:15 -0700
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org,
	Michael Paquier <michael.paquier@gmail.com>
Subject: Re: BUG #16039: PANIC when activating replication slots in Postgres
 12.0 64bit under Windows
Message-ID: <20191010152515.q5uo3pg6ai7ppvd2@alap3.anarazel.de>
References: <16039-196fc97cc05e141c@postgresql.org>
 <20191004200605.yqcmn75otebwcvyj@alap3.anarazel.de>
 <20191006045548.GA14532@paquier.xyz>
 <20191008003240.GA1613@paquier.xyz>
 <20191008160953.odwxuxiy5agci4fj@alap3.anarazel.de>
 <20191009044207.GA21379@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191009044207.GA21379@paquier.xyz>
Precedence: bulk

Hi,

On 2019-10-09 13:42:07 +0900, Michael Paquier wrote:
> > Yuck :(. Luckily that's a pretty narrow case to hit.  We really need
> > windows coverage for this stuff. And also just general buildfarm
> > coverage, it's not like we're immune from bugs on unixoid OSs etiher.
> 
> test_decoding hits that easily for me, and we test that on Windows for
> some time now as there is a buildfarm module.  That's a bit depressing.

Well, that's because it intentionally tries to hit that case ;)

But yea, it's not good.

I think we really ought to remove the -F from pg_regress.c, and leave
that up to the caller. Right now it's just about impossible to
configure without patching the source, unless I miss something.


> >> Andres, others, any thoughts about this issue?  Are there any
> >> objections if I just fix it?
> > 
> > Not here.
> 
> Done this one.

Thanks.

Greetings,

Andres Freund