Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iKEeE-00024H-1A for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Oct 2019 04:41:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iKEeC-0006Vl-Ry for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Oct 2019 04:41:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iKEeC-0006VW-B9 for pgsql-bugs@lists.postgresql.org; Tue, 15 Oct 2019 04:41:24 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iKEe9-00041E-EW for pgsql-bugs@lists.postgresql.org; Tue, 15 Oct 2019 04:41:22 +0000 Received: by mail-io1-xd43.google.com with SMTP id z19so43029331ior.0 for ; Mon, 14 Oct 2019 21:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FH0EQcg1I4HlVinta64dDa+FE4nLzbLIl5hSOuCKIew=; b=inUdgi/c47jMT5Vjc0duJwAJKamG1GUxCbu9Q2+Ubd36/DjwaNGtRcNtrHT7mDSjSQ 3HW8ZEhMDJRKABN9j2s0vFI791O5nQw96jfmMW1drMkFsEKfqdLj1Tr4tYdresuDE63X Zc7JzEjvQ9EvP0Io24BPLZ3/GkxTagWDXLV7bElOQNGCpXH/Oz3RMjAvP+vtmI+wnmb1 YjhVnsjt4tjaqxPelJMYeoqiKRQzobGAvv9EGwHnDYoCbcvKblVejW08oNNiqsMBwUY7 BofdlMR1dSQEMSJzWtFoaj8LN38virm+SBngj3oMPpSI80Du9nlWoXXyoWzN/3J3+9p3 Sjzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FH0EQcg1I4HlVinta64dDa+FE4nLzbLIl5hSOuCKIew=; b=tSmtRYjDvuwXyk30WwB9cwjNHuMYMhh+h6tWl4TLeq8RhtRkSun6E6/gYDinWx4s/P 8CAiQekb9uliqiw6AjewAKtnMPa5NfS+v2fnGieX5ny3oMvKF8ZPfHDW4aaQeUD/BhS6 bHeQKvolJ0p+55dYeytnbLIMHZ+NvIixDJlbTsgpuZToRcYkSrwoBeoAfzcicJYTh6/P 2ZJMom3Esun82g4tTkKXyPHD6ypq3/HkT2QS7jrxlevIkVLLPFAuUxWKM/qjBs24fNXx TfX0sAFiXzg58gajiz9n7dEFHrI+WFv93YSFqqbS7U+axKVf5184pSRyPOlXTjXQGHmD yvRQ== X-Gm-Message-State: APjAAAWBs4tAgBJJIvFCaJKyp3nU5JvjanvdWMC38voFkw1BMkfSpHav juRLTNh1/0OEXjGAzHbmrsPsSw== X-Google-Smtp-Source: APXvYqzaVkon4KdUmy06u1liGazwoCxl0b/FyqOihcGGoa8Jr/qJKK4sCoSo0Y8ZcFYcHE9xW0DbHw== X-Received: by 2002:a02:ad1a:: with SMTP id s26mr40633831jan.61.1571114480589; Mon, 14 Oct 2019 21:41:20 -0700 (PDT) Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id o8sm2658243ild.55.2019.10.14.21.41.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Oct 2019 21:41:19 -0700 (PDT) Received: by pryzbyj (Postfix, from userid 1000) id D09988011CB; Mon, 14 Oct 2019 23:41:18 -0500 (CDT) Date: Mon, 14 Oct 2019 23:41:18 -0500 From: Justin Pryzby To: Tomas Vondra Cc: Tom Lane , Andres Freund , buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12 Message-ID: <20191015044118.GO3599@telsasoft.com> References: <30706.1570717152@sss.pgh.pa.us> <20191010163350.2rtcjtje6tkgilqi@development> <1542.1570738460@sss.pgh.pa.us> <20191010204022.6hiiubm2cueu3ghk@development> <20191013001032.lqrn4kqaovhrf77l@development> <17717.1570991208@sss.pgh.pa.us> <20191013203848.2eksimmpux3546wr@development> <27596.1571062600@sss.pgh.pa.us> <20191014163538.cqn6j4cl7s2mk2yz@development> <20191015001817.zei45apgpu5dzngr@development> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015001817.zei45apgpu5dzngr@development> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Oct 15, 2019 at 02:18:17AM +0200, Tomas Vondra wrote: > On Mon, Oct 14, 2019 at 06:35:38PM +0200, Tomas Vondra wrote: > >... > > > >Aha! I forgot we copy the necessary stuff into pg_attribute. Thanks for > >clarifying, I'll polish and push the fix shortly. Perhaps it'd be worth creating a test for on-disk format ? Like a table with a column for each core type, which is either SELECTed from after pg_upgrade, or pg_dump output compared before and after. Justin