Date: Tue, 15 Oct 2019 09:07:25 +0200
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after
 pg_upgrade from PG11 to PG12
Message-ID: <20191015070725.csmdmdvrlb6klwkg@development>
References: <20191010163350.2rtcjtje6tkgilqi@development>
 <1542.1570738460@sss.pgh.pa.us>
 <20191010204022.6hiiubm2cueu3ghk@development>
 <20191013001032.lqrn4kqaovhrf77l@development>
 <17717.1570991208@sss.pgh.pa.us>
 <20191013203848.2eksimmpux3546wr@development>
 <27596.1571062600@sss.pgh.pa.us>
 <20191014163538.cqn6j4cl7s2mk2yz@development>
 <20191015001817.zei45apgpu5dzngr@development>
 <20191015044118.GO3599@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20191015044118.GO3599@telsasoft.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Mon, Oct 14, 2019 at 11:41:18PM -0500, Justin Pryzby wrote:
>On Tue, Oct 15, 2019 at 02:18:17AM +0200, Tomas Vondra wrote:
>> On Mon, Oct 14, 2019 at 06:35:38PM +0200, Tomas Vondra wrote:
>> >...
>> >
>> >Aha! I forgot we copy the necessary stuff into pg_attribute. Thanks for
>> >clarifying, I'll polish and push the fix shortly.
>
>Perhaps it'd be worth creating a test for on-disk format ?
>
>Like a table with a column for each core type, which is either SELECTed from
>after pg_upgrade, or pg_dump output compared before and after.
>

IMO that would be useful - we now have a couple of these checks for
different data types (line, unknown, sql_identifier), with a couple of
combinations each. And I've been looking if we do similar pg_upgrade
tests, but I haven't found anything. I mean, we do pg_upgrade the
cluster used for regression tests, but here we need to test a number of
cases that are meant to abort the pg_upgrade. So we'd need a number of
pg_upgrade runs, to test that.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services