Date: Wed, 16 Oct 2019 16:33:43 +0200
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, buschmann@nidsa.net,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after
 pg_upgrade from PG11 to PG12
Message-ID: <20191016143343.7tq374yllq3zoglv@development>
References: <20191010204022.6hiiubm2cueu3ghk@development>
 <20191013001032.lqrn4kqaovhrf77l@development>
 <17717.1570991208@sss.pgh.pa.us>
 <20191013203848.2eksimmpux3546wr@development>
 <27596.1571062600@sss.pgh.pa.us>
 <20191014163538.cqn6j4cl7s2mk2yz@development>
 <20191015001817.zei45apgpu5dzngr@development>
 <20191016113344.ihrjpztakfppgilp@development>
 <11353.1571228877@sss.pgh.pa.us>
 <11665.1571232402@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <11665.1571232402@sss.pgh.pa.us>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Wed, Oct 16, 2019 at 03:26:42PM +0200, Tom Lane wrote:
>I wrote:
>> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>>> I've just committed and pushed both fixes after some minor corrections.
>
>> Not quite right in 9.6 and before, according to crake.  Looks like
>> some issue with the CppAsString2'd constants?  Did we even have
>> CppAsString2 that far back?
>
>Yeah, we did.  On closer inspection I suspect that we need to #include
>some other file to get the RELKIND_ constants in the old branches.
>

Yeah, the pg_class.h catalog was missing on pre-10 relases. It compiled
just fine, so I haven't noticed that during the backpatching :-(

Fixed, let's see if the buildfarm is happy with that.

regads

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services