Date: Wed, 6 Nov 2019 13:41:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: The XLogFindNextRecord() routine find incorrect record start
 point after a long continuation record
Message-ID: <20191106044120.GF1604@paquier.xyz>
References: <99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="SxgehGEc6vB0cZwN"
Content-Disposition: inline
In-Reply-To: <99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru>
Precedence: bulk


--SxgehGEc6vB0cZwN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 06, 2019 at 07:40:48AM +0500, Andrey Lepikhov wrote:
> I found this in our multimaster project on PostgreSQL 11.5. It is difficu=
lt
> to reproduce this error, but I will try to do it if necessary.
>=20
> The rest of a continuation WAL-record can exactly match the block size. In
> this case, we need to switch targetPagePtr to the next block before
> calculating the starting point of the next WAL-record.
> See the patch in attachment for the bug fix.

What's the error you actually saw after reading the record in
xlogreader.c?  If you have past WAL archives, perhaps you are able to
reproduce the problem with a given WAL segment and pg_waldump?

This code rings a bell as of this thread which led to commit bab7823:
https://www.postgresql.org/message-id/CABOikdPsPByMiG6J01DKq6om2+BNkxHTPkOy=
qHM2a4oYwGKsqQ@mail.gmail.com

Reminds me as well of the following:
https://www.postgresql.org/message-id/CAOR=3Dd=3D16x+jKM=3D00AoEZEKU9RJDwjU=
9E2bUnFBpX_HrGjkMHXg@mail.gmail.com
--
Michael

--SxgehGEc6vB0cZwN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3CTvAACgkQnvQgOdby
QH2dXw/+OyJ0dJD2QZcOPoNbDP45cNyETqAaiUQ5Z8qthExW54oGut6SroN68Ucj
JoO1J21gH97OFa0NNIspzy6PQOZCgmnChxBICoJYxip+PI7/VmYBbUJl73Q0TPu1
iaYHyOIkMGStdlBef9VjO5yc88Jb0JZ7bXtDeq/c/B7TCELGW9Vi4t2UPFUEe8P4
uyhEzjTYSBJ4f+6snRtSoJLjpealdmE4I9hS4pWzy1wecKoZBxAQy6j287FtpeyM
OlpsJ1uvJr3QGpoSxMI4uUPpxnrOM1yljH6jAuiD4tqDAuQ8BIcxe7qiTdAaz9mr
usM7QAujaYYw3pMk0U2cYxr1TUwRmklbdooNziW0eP+KrguFhmYewEqojCvCMwip
D8rGNOFWEouJqyxHJ1Uz5p7NBB6E1iNHh9+gblkVKKDhIpS59pg44aAm7FCyDvh/
uHjFOtmsVHKDaouDKY+kADnMOTBn5BadaeeAIZrD6vC6b8UzRIwmq4dj9yG556K2
U0siocpGjaATs7mqsFcISjfXy7DR57Z/Z3LdPnYneLpVfzB64gsYOlC/A0QpcQ/w
gGp4UBtFOiY0L3WVTG2IrDsTCGt5v3nH+AlxzWfHFHdQO2rwBWB1uJVAy2+w5EKD
PoJBFZYIyex0WLCSN0znXW8U5Yt9RT/RYXxJy1RrbqgSC6Cq8iU=
=XEub
-----END PGP SIGNATURE-----

--SxgehGEc6vB0cZwN--