Date: Tue, 19 Nov 2019 12:04:28 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Adam Scott <adam.c.scott@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16122: segfault pg_detoast_datum (datum=0x0) at fmgr.c:1833
 numrange query
Message-ID: <20191119030428.GD1614@paquier.xyz>
References: <16122-eb35bc248c806c15@postgresql.org>
 <20191118120312.cblcswef6vuqbijq@development>
 <CA+s62-Mnj-x8_ZXh7tBVU3WJ3cKUsUL2HAp2YaJSXQPw1iypFw@mail.gmail.com>
 <20191119014827.GC1614@paquier.xyz>
 <CA+s62-OQg3YFTE830o14eFWKdsGy2wKR4Z7aK_PbK4rdM8Y1Gg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="UfEAyuTBtIjiZzX6"
Content-Disposition: inline
In-Reply-To: 
 <CA+s62-OQg3YFTE830o14eFWKdsGy2wKR4Z7aK_PbK4rdM8Y1Gg@mail.gmail.com>
Precedence: bulk


--UfEAyuTBtIjiZzX6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 18, 2019 at 06:22:11PM -0800, Adam Scott wrote:
> Maybe a clue to the issue, why does a numrange need to be detoasted since
> that is for large strings?

I looked at the code a bit but could not really figure out what could
go wrong.  Then I switched my strategy and bisected for the first
commit leading to the failure, and this is pointing me to the
integration of stdbool.h for my environment (Debian SID with kernel at
5.3):
commit: 9a95a77d9d5d3003d2d67121f2731b6e5fc37336
author: Peter Eisentraut <peter_e@gmx.net>
date: Thu, 22 Mar 2018 20:42:25 -0400
Use stdbool.h if suitable

Using the standard bool type provided by C allows some recent compilers
and debuggers to give better diagnostics.  Also, some extension code and
third-party headers are increasingly pulling in stdbool.h, so it's
probably saner if everyone uses the same definition.

I have also checked that manually and I am getting a match.  And the
thing is that this commit did not make it through 10...
--
Michael

--UfEAyuTBtIjiZzX6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3TW7wACgkQnvQgOdby
QH2Z5Q/+JjX+uVGUU4WGW0GXoAVr2k9S7JOjZPwlE+dydBJ1ZnKIVYNknev2qLyo
3T36e7Z6fWj+4LKZPTslKGktLUUdv7BeNxaykFjEIXqf3AwEtfAjRWGxY95VtjL3
m/LKapakP5IMQYDjSkZJ0D8CXfF9bTm1tJq/iwaTQVItUUKQSfH18FQddsiq9O+r
N35gfr8TVv2yyux5i3e1f6r0x03MM66hDA3pJV7+SP88Z5Oi1e5rOmTQRYJOlONR
PTF0CL+YToDgGuPBi26oefNkVrVo8BQJV2GQ90DbtVLDaYeFPYMIkPZJtwYemG3X
ICd9QjnThVzDmeUCOz/2je9VDZUohpo8NQeqx4GSG+KEdHNuIz6G7rBNChp4gaxK
vKq1xyx4gT/89avy4SuJRSSvSdSMqFqgVyy3AkI00u8zdDy2ijHy0VeGdBXtQAzc
fWrSxu4W6l4IwtxXRqLYOQ3ZqKDZyCeFDvg9q5qiVA4wwYIYDZQ/VPVKiewZSiqK
XgXe2vysj1ErpXcnPe9kWeMSY9tKaTxP31levf4dJFHfYDiiRu469vsXlt+acqe6
/EhpQy23JZSxhKAWtyqN0O5Un51qRfaeHHB2mTNLz8CarMhXWq7S2MsaHakI1WM1
/6AMvMv0vTVO5Ns8KU7cZWWw1DHr/nNGGgr/IJspOIiQcBXMyuU=
=4n9p
-----END PGP SIGNATURE-----

--UfEAyuTBtIjiZzX6--