Date: Thu, 21 Nov 2019 15:31:59 +0100
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: =?utf-8?Q?Ond=C5=99ej?= Jirman <ienieghapheoghaiwida@xff.cz>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16129: Segfault in tts_virtual_materialize in logical
 replication worker
Message-ID: <20191121143159.zlaxfp7kzjcsyydn@development>
References: <16129-a0c0f48e71741e5f@postgresql.org>
 <20191121103940.gpadc7xmssl63sad@development>
 <20191121115326.arierrbeok6we5sv@core.my.home>
 <20191121125930.or5fhpi2yjgkmjye@development>
 <20191121131202.xhi5hxvdjjfvbmop@core.my.home>
 <20191121133714.dezdkhqjuzejoegb@development>
 <20191121134645.vrezfwccclnurh5k@core.my.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191121134645.vrezfwccclnurh5k@core.my.home>
Precedence: bulk

On Thu, Nov 21, 2019 at 02:46:45PM +0100, Ondřej Jirman wrote:
>On Thu, Nov 21, 2019 at 02:37:14PM +0100, Tomas Vondra wrote:
>> On Thu, Nov 21, 2019 at 02:12:02PM +0100, Ondřej Jirman wrote:
>> > On Thu, Nov 21, 2019 at 01:59:30PM +0100, Tomas Vondra wrote:
>> > > On Thu, Nov 21, 2019 at 12:53:26PM +0100, Ondřej Jirman wrote:
>> > > >
>> > > > ...
>> > > >
>> > > OK, so this is the problematic table. Any idea what operation triggers
>> > > the issue? Having a small reproducer (say, a single-row insert or so)
>> > > would be very helpful.
>> >
>> > Can something be extracted from the logical decoding data I sent in the other
>> > e-mail? That seems to contain the failing operation, but I don't know how to
>> > decode it off the top of my head from that binary representation.
>> >
>>
>> Well, why not use pg_logical_slot_peek_changes()? That should be human
>> readable, I think.
>
>I would, but how?
>
>SELECT * FROM pg_logical_slot_peek_changes('l5_hometv', NULL, NULL,
>		'proto_version', '1', 'publication_names', 'pub');
>ERROR:  logical decoding output plugin "pgoutput" produces binary output, but
>function "pg_logical_slot_peek_changes(name,pg_lsn,integer,text[])" expects
>textual data
>

Ah, right. Sorry, I forgot this is pgoutput.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services