Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZzLZ-0002o0-7X for pgsql-bugs@arkaria.postgresql.org; Wed, 27 Nov 2019 15:35:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iZzLX-0005dw-S2 for pgsql-bugs@arkaria.postgresql.org; Wed, 27 Nov 2019 15:35:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZzLX-0005dm-Ja for pgsql-bugs@lists.postgresql.org; Wed, 27 Nov 2019 15:35:15 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZzLU-0004y7-Ml for pgsql-bugs@lists.postgresql.org; Wed, 27 Nov 2019 15:35:15 +0000 Received: by mail-wm1-x341.google.com with SMTP id f129so8030057wmf.2 for ; Wed, 27 Nov 2019 07:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fOgaXMs2o6HLbUlioAP4b+TkQVWrpilbRH1cpibuM4E=; b=UYxpWkgdoWFAjGl1TYztuZAnJ68pIip1B2amaBd5EpHI5Tru7PkTIDPLWFvcVz0uyq tHs1AUkoPiwMAOBLAiDvuJGpjiHTL5GqIB2cM9X+962nrgZ+qYrtFdYTqz6xqq4Ttkrh sVBoV5GuNRPITRdUQzT3AZg32Hv1oi32cIYpfXASraV6Ka475auDlapQssD4X2/XOpsK PscwwtBpWCT3uQ4kxvWObQWGrR+rKjhKMdqi3R7/kAV1quaKdffyyOU/TTnDIb/9+pIi F20DqUJfIP4SEpRe1X3jC/eIiMHjWS6hXIFNmtKWA4L04FRSt8gHMzEJ9/AkV8GusJ7x Z1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fOgaXMs2o6HLbUlioAP4b+TkQVWrpilbRH1cpibuM4E=; b=dfjn20ugYPYQzzigFBWhsBG+Tx/6wputZNdKvqCY9HzYK/b3x2Z0RTlFoT4AoN9y/Y g5/8ewvcd1WrgxvCpXwGSxwf7w4LUXgdO9COam1XyqwLREfwvLpAdrGgxs+iFgdsBBf2 8u5UfKu2QdoaAeXAAS7+T1/ykUMJSrBi58gxonEQ66DETQL93AC/g9+AboyMJ/UUMZOV P1n4aewqsp1+dtZfkYEffP7Sbo1fs7JFHn315ZcFsog+a/qStSDl5kbYEIQME11kyqfE KIvwWJ4li2W8lPvVlhaB9KGIe4KR/JzjeEk7msbyQ+uY/rT2qQmWriKWux4QyN1ZZMkt DrrA== X-Gm-Message-State: APjAAAXhPpxghs0G28DCIjpF/02T+m777WryJyYdygRn/P4wHZvjWyK2 jsHMRc3fcp7+4lCMu8X+TV5sTA== X-Google-Smtp-Source: APXvYqweratAIXQE5w13yzTcO938zySwTZMZum3V/1adKoUSjDSBhodE5P8F6BGdbAqzf6MXWv2k8g== X-Received: by 2002:a7b:c004:: with SMTP id c4mr4836643wmb.45.1574868910561; Wed, 27 Nov 2019 07:35:10 -0800 (PST) Received: from localhost (static-84-42-175-93.net.upcbroadband.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id j67sm7475442wmb.43.2019.11.27.07.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 07:35:09 -0800 (PST) Date: Wed, 27 Nov 2019 16:35:06 +0100 From: Tomas Vondra To: Alvaro Herrera Cc: Andres Freund , Andrey Salnikov , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16125: Crash of PostgreSQL's wal sender during logical replication Message-ID: <20191127153506.tuqlckfj426rkrlb@development> References: <20191119232849.qhtuhq4udrqrz4he@alap3.anarazel.de> <20191127142204.GA13686@alvherre.pgsql> <20191127145700.GF4161@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191127145700.GF4161@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Nov 27, 2019 at 11:57:00AM -0300, Alvaro Herrera wrote: >On 2019-Nov-27, Alvaro Herrera wrote: > >> I think pg_waldump should print out the speculativeness of an insertion. > >Ah, in pg12 we do print the "flags" for the insertion. But earlier >releases don't. IMO we should have backpatched that change, as I said >in https://postgr.es/m/20180423160216.m2yjhx67grofg7h5@alvherre.pgsql >but I was outvoted. > Hmmmm, yeah. I still think the decision not to backpatch was reasonable, although it seems it might have been useful in this particular case. But hey, it should not be that difficult to build a custom pg_waldump version with that patch applied, and decode the WAL segment. It can even be done on a completely separate system, it's just a single binary. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services