Date: Tue, 3 Dec 2019 15:10:02 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Magnus Hagander <magnus@hagander.net>
Cc: Thomas Munro <thomas.munro@gmail.com>, k.yudhveer@gmail.com,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16079: Question Regarding the BUG #16064
Message-ID: <20191203201002.GQ6962@tamriel.snowman.net>
References: <16079-29e9c038e1463751@postgresql.org>
 <20191028154754.GS6962@tamriel.snowman.net>
 <CA+hUKGJw4Ax25=fcCA+DQD=82v2pKu9VGmkYZO8HeH7+-P2Cxw@mail.gmail.com>
 <CABUevEwMcFmXqPJgOQfnUV8XgKtWqHPiccNHY+mPJ0AfeFz-7Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iUAJABEbie0DfC6a"
Content-Disposition: inline
In-Reply-To: 
 <CABUevEwMcFmXqPJgOQfnUV8XgKtWqHPiccNHY+mPJ0AfeFz-7Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--iUAJABEbie0DfC6a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Magnus Hagander (magnus@hagander.net) wrote:
> On Fri, Nov 15, 2019 at 5:42 AM Thomas Munro <thomas.munro@gmail.com> wro=
te:
>=20
> > On Tue, Oct 29, 2019 at 4:48 AM Stephen Frost <sfrost@snowman.net> wrot=
e:
> > > Uh, the user's credentials certainly are sent to the PG server.
> >
> > Perhaps we should log a warning when PostgreSQL has received a
> > password over the network without SSL.  Perhaps we should log another
> > warning when PostgreSQL has sent a password over the network without
> > SSL.
>=20
> For the old plaintext "password" method, we log a warning when we parse t=
he
> configuration file.
>=20
> Maybe we should do the same for LDAP (and RADIUS)? This seems like a bett=
er
> place to put it than to log it at every time it's received?

Seems like a reasonable approach to me though we should probably also
include details in the documentation around what this warning means,
exactly, since we probably can't write the full paragraph or more that
we'd need to inside the warning itself.

Sorry though..  where do we log that warning you're talking about wrt
the 'password' method?  I just started a 13devel with 'password'
configured in pg_hba.conf and didn't see any warnings...

(commit b5273943679d22f58f1e1e269ad75e791172f557)

I'm all for adding a warning when any of these methods is used, maybe
with an optional override of "yes, I know this is bad but I don't care".

Thanks,

Stephen

--iUAJABEbie0DfC6a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJd5sEaAAoJEO1sijiDR2RV/8UP/1q9Obk0fb3Y9HrkTKSm89Ef
oZ7sKqy3w6DZTlgHfKnHsHv7JYOPs/UqcO31l2vEnRkW590ZVu2kV9ThtpQ+Wkcd
cyozJtliwpQOE+AQe/L04PuqyPcgB4se0zZDnvw2H/qpe4s3B3hEmO+yjEYA347U
hufEv6XCupSt+31rPzm+KJFi99/usrPpCRrBI2UGcrRXioxIPGEHqD89HnwCOgRX
JsuGe1aVAFNvsTw6tDU+sEn1bGAeJJDMu5rr1/03dQXFjmAc/AMPlVKXuCqIL3Q2
+ApIS3LDS1PC5hOzbtAU2hXwymXb6KqT+tfdVirKUUL0kfxx1N3siVGMGAIz6afF
3txyZsKerQYYZTv7kIruy+o11MqkI1M6xbQt2rYbQQrJavFjpWCSx08dtiI1tv4u
y/d0bceLax0UqnMIt6Os6leEiEZcLuz1HfQ+b7AsPtgkvGspPoakLMAJUxPLmoTh
4od9aUk1ECElPNsdYAA3hE0ehPa6lZi6X+zxwnGS5HxpT5l2zc9YJzrHB3oUeVgE
QbtDsrWdehBRZeU//d0tRgnxBBxmkOfgarFl/4CN6i+Ppg8JwjlNftv8gbhoV9uw
+KPKS/ftzPWkfsT6/gppb9JWxSHmKbiaBg/e4bXkxUiWPMNhonEPl8ix5jIzvR7e
weFgP9/H0QX4HgW19CV+
=uyd+
-----END PGP SIGNATURE-----

--iUAJABEbie0DfC6a--