Date: Wed, 11 Dec 2019 12:06:37 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes
 required quotes
Message-ID: <20191211150637.GA21159@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+Tgmoajh2XZ3Z8o6p7mftsfK5owqy3F5o05rNaAW==rF90+tQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Dec-11, Robert Haas wrote:

> On Sun, Nov 3, 2019 at 5:40 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Of course, this only works if we have those hooks :-(.  So far as
> > I can tell, all libreadline variants that might still exist in the wild
> > do have them; but libedit doesn't, at least not in the version Apple
> > is shipping.  Hence, what the attached patch does is to make configure
> > probe for the existence of the hook variables; if they're not there,
> > fall back to what I proposed previously.
> 
> Are people still compiling against libedit and then redirecting to
> libreadline at runtime? I seem to recall some discussion about this
> being a thing, many years ago.

Yeah, Debian did that out of licensing concerns.  It seems they still do
that, based on
https://packages.debian.org/bullseye/postgresql-client-12

> If it were being done it would be
> advantageous to have the checks be runtime rather than compile-time,
> although I guess that would probably be tough to make work.

Yeah.  On the other hand, I suppose Debian uses the BSD version of the
libraries, not the Apple version, so I think it should be fine?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services