Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1if3lT-0002uM-TS for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Dec 2019 15:19:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1if3lS-0005cW-NC for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Dec 2019 15:18:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1if3lS-0005cP-E3 for pgsql-hackers@lists.postgresql.org; Wed, 11 Dec 2019 15:18:58 +0000 Received: from mail-vs1-xe41.google.com ([2607:f8b0:4864:20::e41]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1if3lP-0003OF-F2 for pgsql-hackers@lists.postgresql.org; Wed, 11 Dec 2019 15:18:58 +0000 Received: by mail-vs1-xe41.google.com with SMTP id g23so16015082vsr.7 for ; Wed, 11 Dec 2019 07:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=xUZVU4IwtT+EtmXODc4KoKQ6mA4pi32z3UDtAcwr0FY=; b=fBmf2/XHRNIaEACGFR5/UrnJP2tq6wsym4Xcs1JcsqL1AFqJvFQxP/LZptOyanzmdy vGTbdM/tTGNenUf8b50yrbJNFNJPhkOlPltopgGiX8rKjK/UM0eVHN1nugKgfxkN0Wvj wdiL2ClyFOx9iXPDqHscvoiB0houEiEA6LNzI/sGiJXHpQNjQZHJvcCbqNmJPKJEgKWJ bKqvEXAQF8IqLovIkrcmqx3A8uCtt0oH5dkvm1osnr2h36St7J9N+nwdEVqvLDnNQKv3 85lFq1xHiIZKMg70Ai4cboj8+mzoBoDag/oL4EywRk6kyWxRflYpZySAQ1UEyU4JTT78 C+ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=xUZVU4IwtT+EtmXODc4KoKQ6mA4pi32z3UDtAcwr0FY=; b=S2kwlYalZ5QXfeiIoyW1IvJ1yPNyTlDYo08pOy9cqdfTilALfy4mtedBWfGoIc9isr lNCU1Z1C0CeKldwkdVG5TZ3CqX3LkuFY3Yi/2GpQOTGGweJmERMtymdSZQ9hWgSuHYP/ 0NG7eBMPD0lBG9utY+jU1F5v8s5hTI+W2PkZKIwY847qevdt+6n9hXzuFetYkvewbVJL qcYgIN4gf2I8IkXYT2FnF0rZqjRao6iJdBqF5v4A6Y65z/hUxPPH+VNrWnrSmTYicsia 3Jj/sYq1iH9KBGGfKCbETNhtw8UQO+iiIz4z+EJ+5lj9PFgTvneUgC+aCXnqfnuBRQQh 7wBw== X-Gm-Message-State: APjAAAVM+D5+bm6/2e2rs0yM2uKHNUFAyhCsstV2nncR77JIUvjJVAyp aywaMl/eUU89yy42BTIWR2ZesA== X-Google-Smtp-Source: APXvYqyZZEQyHxfU/Dd5cb2VUs4+xVn1VFbqDSfOHG+YVWXiyHkaBikynHgqmmhEosZ22Tw6UvZBVg== X-Received: by 2002:a67:c097:: with SMTP id x23mr3164611vsi.164.1576077533607; Wed, 11 Dec 2019 07:18:53 -0800 (PST) Received: from nimloth.alvh.no-ip.org ([190.95.19.128]) by smtp.gmail.com with ESMTPSA id s3sm1253432vsi.12.2019.12.11.07.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 07:18:53 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id AC19F3009ED; Wed, 11 Dec 2019 12:18:35 -0300 (-03) Date: Wed, 11 Dec 2019 12:18:35 -0300 From: Alvaro Herrera To: Robert Haas Cc: Tom Lane , PostgreSQL Hackers , steven.winfield@cantabcapital.com Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes Message-ID: <20191211151835.GA22510@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191211150637.GA21159@alvherre.pgsql> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Dec-11, Alvaro Herrera wrote: > On 2019-Dec-11, Robert Haas wrote: > > If it were being done it would be > > advantageous to have the checks be runtime rather than compile-time, > > although I guess that would probably be tough to make work. > > Yeah. On the other hand, I suppose Debian uses the BSD version of the > libraries, not the Apple version, so I think it should be fine? ... actually, grepping libedit's source at http://deb.debian.org/debian/pool/main/libe/libedit/libedit_3.1-20191025.orig.tar.gz there's no occurrence of rl_filename_quoting_function. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services